Page MenuHomePhabricator

action: "window-open-from-tool" is showing up instead of "action": "external-link-input" when a user clicks on "Link"
Closed, ResolvedPublic

Description

This task is about making it so the correct event is fired when people click the "🔗" icon in the Reply tool's visual text input mode.

Behavior

  1. Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats?trackdebug=1
  2. Click any "Reply" link
  3. Open the Reply tool's visual mode
  4. Click the the "🔗" icon in the toolbar

Expected

  1. Awaiting confirmation from @Mayakp.wiki

Actual

  1. Observe the following event is shown in the console as being logged:
"editor_interface": "visualeditor"
"schema": "VisualEditorFeatureUse"
"feature": "link"
action: "window-open-from-tool"

Done

  • The Expected behavior has been implemented

Event Timeline

@Mayakp.wiki can you confirm what event should be fired when people click the "🔗" icon in the Reply tool's visual text input mode?

The Replying QC template suggests the following event should be fired:

"editor_interface": "visualeditor"
"schema": "VisualEditorFeatureUse"
"feature": "link"
action: "external-link-input"

When I wonder whether what event should - and currently is – being fired should be:

"editor_interface": "visualeditor"
"schema": "VisualEditorFeatureUse"
"feature": "link"
action: "window-open-from-tool"

@DLynch, on second read, is the question in T255639#6236654 better suited for you?

Hi @ppelberg, I agree, it would be better if David could answer this.
sidenote: not sure why but I never got an email or notified for the ping on June 18. sorry about that.

The Replying QC template suggests the following event should be fired:

That's just the template being wrong. The window-open-from-tool is what's expected -- external-link-input is what's fired when you type in the field inside the link window.

I've updated the spreadsheet to have the correct event.

Thanks @DLynch for the clarification and update.
I have added a new test scenario for when you type in the field inside the link window. Can you confirm if its correct?

When user clicks on "Link" i.e. "🔗" icon to add a hyperlink on selected text and types in the field inside the link window

"feature": "link"
"action": "external-link-input"

So long as it's in the external link tab, yes. Internal link would be different.

ppelberg claimed this task.

Just confirmed with @Mayakp.wiki that this event is being logged correctly.