"Bad content model: expected wikitext but got javascript" while saving/stashing an edit
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.37

message

MWException: Bad content model: expected wikitext but got javascript.

Impact

Notes

Seems to happen when editing https://fa.wikipedia.org/w/index.php?title=%D9%BE%DB%8C%D8%B4%E2%80%8C%D9%86%D9%88%DB%8C%D8%B3:Gadget-twinkleblock-2020.js

Details

Request ID: 35714809-dd50-47c5-9b37-2fa00d4a7bf2
Request URL: https://fa.wikipedia.org/w/api.php

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.37/includes/content/TextContentHandler.php(70): ContentHandler->checkModelID(string)
#1 /srv/mediawiki/php-1.35.0-wmf.37/includes/api/ApiStashEdit.php(120): TextContentHandler->merge3(WikitextContent, WikitextContent, JavaScriptContent)
#2 /srv/mediawiki/php-1.35.0-wmf.37/includes/api/ApiMain.php(1585): ApiStashEdit->execute()
#3 /srv/mediawiki/php-1.35.0-wmf.37/includes/api/ApiMain.php(525): ApiMain->executeAction()
#4 /srv/mediawiki/php-1.35.0-wmf.37/includes/api/ApiMain.php(496): ApiMain->executeActionWithErrorHandling()
#5 /srv/mediawiki/php-1.35.0-wmf.37/api.php(84): ApiMain->execute()
#6 /srv/mediawiki/w/api.php(3): require(string)
#7 {main}

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	API: Handle ContentHandler exception for content model mismatch	mediawiki/core	master	+86 -3

Customize query in gerrit

Related Objects

Mentioned In: Blog Post: Production Excellence #22: June 2020
Mentioned Here: T206253: Some ApiParse requests fail due to fatal MWException: "not supported for content model"

Event Timeline

• thcipriani created this task.Jun 17 2020, 6:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2020, 6:15 PM

Krinkle renamed this task from Bad content model: expected wikitext but got javascript. to MWException: "Bad content model: expected wikitext but got javascript" (ContentHandler.php).Jun 17 2020, 6:47 PM

Krinkle triaged this task as High priority.

Krinkle added projects: MediaWiki-Core-Revision-backend, Platform Engineering.

Krinkle updated the task description. (Show Details)

Krinkle moved this task from Untriaged to Jun 2020 on the Wikimedia-production-error board.

The page was originally created in Draft namespace (default contentmodel = wikitext ). The author likely then attempted editing it, thus the revision he fetched was in wikitext contentmodel. He took like 17 minutes working on the edit, and in the meanwhile, the content model of the page was changed to javascript. Later when he wanted to save, exception was thrown in ContentHanlder since the page now has content model different from that of the fetched revision. In EditPage this is handled with 'contentmodelediterror' error, but the API is not handling it.

DannyS712 subscribed.Jun 20 2020, 3:57 PM

Ammarpad claimed this task.Jun 20 2020, 3:58 PM

Ammarpad edited projects, added MediaWiki-Action-API; removed MediaWiki-ContentHandler.

Change 606844 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] API: Handle ContentHandler exception for content model mismatch

https://gerrit.wikimedia.org/r/606844

gerritbot added a project: Patch-For-Review.Jun 21 2020, 10:25 PM

This may duplicate T206253 - unclear.

Krinkle renamed this task from MWException: "Bad content model: expected wikitext but got javascript" (ContentHandler.php) to "Bad content model: expected wikitext but got javascript" while saving/stashing an edit.Jun 24 2020, 6:22 PM

BPirkle edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Jun 24 2020, 8:38 PM

Krinkle mentioned this in Blog Post: Production Excellence #22: June 2020.Jul 23 2020, 3:25 AM