Cannot download media (Uncaught TypeError: Cannot read property 'getMIMEType' of undefined / TypeError: this is undefined)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 17 2020, 9:29 PM

Description

Replication steps:

Visit https://commons.wikimedia.org/wiki/File:En-us-sit.ogg# in CHROME
Click settings
Click download icon

Screen Shot 2020-09-10 at 4.08.15 PM.png (924×2 px, 463 KB)

Note on Firefox this shows up as the error: "TypeError: this is undefined"

Error information

Noticed this error while going through the error logs

user agent:
Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/81.0.4044.138 Safari/537.36 OPR/68.0.3618.125

Stack trace:

at URL1:125:759
at Object.showDownloadWithSources  URL1:125:288
at Object.showDownload  URL1:124:930
at Object.showMenuItem  URL1:140:156
at HTMLLIElement.<anonymous>  URL1:139:680
at HTMLLIElement.dispatch  URL2:73:742
at HTMLLIElement.elemData.handle  URL2:70:388

URL1: https://www.mediawiki.org/w/load.php?lang=en&modules=fullScreenApi%7Cjquery.debouncedresize%2CembedMenu%2ChoverIntent%7Cjquery.ui.touchPunch%7Cmediawiki.UtilitiesTime%2CabsoluteUrl%2Cclient%7Cmediawiki.language.names%7Cmw.Api%2CEmbedPlayer%2CEmbedPlayerNative%2CEmbedTypes%2CMediaElement%2CMediaPlayer%2CMediaPlayers%2CMediaSource%2CMediaWikiPlayerSupport%2CTextSource%2CTimedText%2CajaxProxy&skin=vector&version=1npkk
URL2: https://www.mediawiki.org/w/load.php?lang=en&modules=Spinner%2Cjquery%7Cext.tmh.OgvJsSupport%7Cjquery.embedPlayer%2CloadingSpinner%2CmwEmbedUtil%2CtriggerQueueCallback%7Cmw.EmbedPlayer.loader%7Cmw.MediaWikiPlayer.loader%7Cmw.MwEmbedSupport%2CPopUpMediaTransform%7Cmw.MwEmbedSupport.style%7Cmw.PopUpMediaTransform.styles%7Cmw.TMHGalleryHook.js%7Cmw.TimedText.loader&skin=vector&version=1m2o9

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.06.17/clienterror/?id=AXLD34ttK6TSR36GQJV0

Details

	Subject	Repo	Branch	Lines +/-
	Use `source` rather than `this`	mediawiki/extensions/TimedMediaHandler	master	+1 -1

Customize query in gerrit

Related Objects

Duplicates Merged Here: T261965: `TypeError: this is undefined` when clicking download

Event Timeline

Jdlrobson created this task.Jun 17 2020, 9:29 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 17 2020, 9:29 PM

This is a code path in the Kaltura JS player.
https://gerrit.wikimedia.org/g/mediawiki/extensions/TimedMediaHandler/+/12e875c99a7fd7309ed8c402c3c21518c69c3b3f/resources/mwembed/EmbedPlayer/skins/mw.PlayerControlBuilder.js#2155

He, it auto-removed the other one. Didn't mean that. Nevermind :)

The Kaltura path will be switched off soon.

Krinkle moved this task from Untriaged to Older on the Wikimedia-production-error board.Jun 24 2020, 7:02 PM

Umherirrender added a project: JavaScript.Jul 17 2020, 7:59 PM

@Krinkle do you know when? This is causing about 3% of all the errors we're logging so is a significant bug.

DannyS712 subscribed.Sep 10 2020, 12:21 AM

Is there a reproducible issue with the general workflow of video playback?

I don't know the ETA currently. \cc @brion.

It's causing about 7% of all our client side errors (including gadgets) and is stopping users from downloading files so I'd live to bump this to high for now.

Jdlrobson renamed this task from Uncaught TypeError: Cannot read property 'getMIMEType' of undefined to Uncaught TypeError: Cannot read property 'getMIMEType' of undefined / TypeError: this is undefined.Sep 10 2020, 11:10 PM

Jdlrobson renamed this task from Uncaught TypeError: Cannot read property 'getMIMEType' of undefined / TypeError: this is undefined to Cannot download media (Uncaught TypeError: Cannot read property 'getMIMEType' of undefined / TypeError: this is undefined).

Jdlrobson updated the task description. (Show Details)

Jdlrobson merged a task: T261965: `TypeError: this is undefined` when clicking download.

Jdlrobson raised the priority of this task from Medium to High.Sep 14 2020, 4:05 AM

Jdlrobson updated the task description. (Show Details)Sep 18 2020, 9:53 PM

Change 628456 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/TimedMediaHandler@master] Use source rather than this which doesn't refer to anything

https://gerrit.wikimedia.org/r/628456

gerritbot added a project: Patch-For-Review.Sep 18 2020, 10:00 PM

This bug was pretty easy to replicate and fix using debugger and breaking and the fix seemed pretty obvious to me.

Given the volume on this bug I'm a little worried this is going to cause problems as we roll out client side error logging further. @brion could you please take a look at the proposed fix before next branch cut? I'd appreciate it a lot!

Change 628456 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Use source rather than this

https://gerrit.wikimedia.org/r/628456

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.10; 2020-09-22).Sep 18 2020, 11:00 PM

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2020, 11:10 PM

Clear tail off with group1 wikis after Wednesday deploy.

	F32361641: Screen Shot 2020-09-23 at 9.32.21 PM.png
	Sep 24 2020, 2:55 PM

	F32361639: Screen Shot 2020-09-23 at 9.31.49 PM.png
	Sep 24 2020, 2:55 PM

	F32254938: Screen Shot 2020-09-10 at 4.08.15 PM.png
	Sep 10 2020, 11:08 PM

Cannot download media (Uncaught TypeError: Cannot read property 'getMIMEType' of undefined / TypeError: this is undefined)Closed, ResolvedPublicActions