Page MenuHomePhabricator

Handling failed requests to the federation source Wiki when initiating an edit
Closed, ResolvedPublic8 Estimated Story Points

Description

If the connection to the federation source Wiki becomes unavailable between when the page is loaded and when I click on the Edit pen on a statement, I am still able to open the edit console. A request will go out to format the existing value in the statement which then fails. The original value disappears and I cannot add a new one or save.

If the request fails when I click the edit button, I should not be able to access the edit console. An error message should be displayed stating that the connection to the source Wiki is temporarily unavailable.

BDD (Scenario: Clicking the edit button when connection is not available)
Given I have loaded an item page containing statements with federated properties
And the connection to the source Wiki is interrupted
When I select the Edit button on a statement
Then a notification modal is displayed that explains why I cannot edit the statement [see mock]
And the edit console does not open

BDD (Scenario: Dismissing the notification)
Given I have clicked the Edit button and the modal appears stating that the source Wiki is unavailable
When I select the Try again button
Then the modal is dismissed

Mock (updated)

image.png (249×546 px, 15 KB)

Figma
Figma File (Solution1)

Event Timeline

Samantha_Alipio_WMDE renamed this task from Handling failed requests to the federation source Wiki when I initiate an edit to Handling failed requests to the federation source Wiki when initiating an edit.Jun 18 2020, 9:59 AM

Change 620991 had a related patch set uploaded (by Rosalie Perside (WMDE); owner: Rosalie Perside (WMDE)):
[mediawiki/extensions/Wikibase@master] [WIP] Handling failed requests to the federation source Wiki when initiating an edit

https://gerrit.wikimedia.org/r/620991

toan added a subscriber: toan.
Addshore triaged this task as High priority.Sep 3 2020, 9:07 AM

Change 620991 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Handling failed requests to the federation source Wiki when initiating an edit

https://gerrit.wikimedia.org/r/620991