Page MenuHomePhabricator

Refactor breakdowns so they allow more than one dimension to be active
Closed, ResolvedPublic

Description

Right now the concept of breakdowns is hardwired to only handle one dimension at once (activeBreakdown). To enable simultaneous filtering and splitting, I think we need to:

  • Sunset the concept of "Breakdowns" and replace it with "Dimensions".
  • Right now we have an enormous Breakdowns Vue component. The also enormous GraphModel class handles most of the data logic related to breakdowns. We should create a Dimension model class that would remove a lot of business logic from the GraphModel while simplifying the data flow.
  • Replace activeBreakdown with activeSplit. We want multiple dimensions to be able to be active, but only one should split at a time.

Event Timeline

fdans created this task.Jun 18 2020, 10:15 AM
fdans triaged this task as High priority.Jun 18 2020, 4:14 PM
fdans moved this task from Incoming to Wikistats on the Analytics board.

Change 612574 had a related patch set uploaded (by Fdans; owner: Fdans):
[analytics/wikistats2@master] [wip] Allow more than one dimension to be filtered in Wikistats

https://gerrit.wikimedia.org/r/612574

Change 612574 merged by Milimetric:
[analytics/wikistats2@master] Allow more than one dimension to be filtered in Wikistats

https://gerrit.wikimedia.org/r/612574

fdans closed this task as Resolved.Thu, Oct 29, 4:21 PM