Page MenuHomePhabricator

Error in pushing code to Gerrit for the phab-deployment repository
Closed, ResolvedPublic

Description

Status

vidhimody@MacBook-Pro ~/deployment wmf/stable โ†‘1 git review -R     
No '.gitreview' file found in this repository. We don't know where
your gerrit is.
Please manually create a remote named "gerrit" or rename the default
one and try again.

TODO

  • rebase the patch on top of 613657 (until it's merged)

Steps to reproduce the error:

  1. git clone ssh://gerrit.wikimedia.org:29418/phabricator/deployment
  2. Make the necessary changes
  3. Commit the changes
  4. Push the code to Gerrit ( git review )

Event Timeline

Restricted Application added a subscriber: Aklapper. ยท View Herald TranscriptJun 18 2020, 10:36 AM

According to package.json, repository is hosted on phabricator, not gerrit. I guess gerrit repository is just a mirror.

From package.json:

"url": "ssh://vcs@git-ssh.wikimedia.org/source/phab-deployment.git"

@20after4 can you confirm that?

If that's the case, what does @Vidhi-Mody need to do to update the repository? Just add the correct git remote and push to phabricator instead of gerrit?

@mmodell is working on making the gerrit repository the default one.

@Vidhi-Mody can you try it again and let me know if it's still not letting you submit a patch?

@mmodell I get this error when I try pushing a patch to Gerrit:

vidhimody@MacBook-Pro ~/deployment wmf/stable โ†‘1 git review -R     
No '.gitreview' file found in this repository. We don't know where
your gerrit is.
Please manually create a remote named "gerrit" or rename the default
one and try again.

@Vidhi-Mody: I guess you could work around locally by creating the file .gitreview with something like this as its content:

[gerrit]
host=gerrit.wikimedia.org
port=29418
project=phabricator/deployment.git
track=1
defaultbranch=master
defaultrebase=0

Change 613657 had a related patch set uploaded (by Zfilipin; owner: Zfilipin):
[phabricator/deployment@wmf/stable] Add .gitreview file

https://gerrit.wikimedia.org/r/613657

Thanks @mmodell and @Aklapper for the help! ๐Ÿ‘

Change 613657 merged by 20after4:
[phabricator/deployment@wmf/stable] Add .gitreview file

https://gerrit.wikimedia.org/r/613657