Page MenuHomePhabricator
Create Task
Maniphest T255769

Replace `DiffViewHeader` hook with one that doesn't use Revision objects
Closed, ResolvedPublic
Actions

Assigned To
DannyS712
Authored By
DannyS712
Jun 18 2020, 1:20 PM
Tags
Referenced Files
None
Subscribers
Aklapper
BPirkle
cicalese
daniel
DannyS712
• Pchelolo
thiemowmde

Description

Currently, the DiffViewHeader hook's second and third parameters are Revision objects (or null). These can be replaced with RevisionRecord objects. However, those RevisionRecord objects correspond to the return values of the DifferenceEngine's (first hook parameter) getOldRevision and getNewRevision, so really the replacement only needs to pass a DifferenceEngine

New name: DifferenceEngineViewHeader (to match DifferenceEngineOldHeaderNoOldRev)

Deployed extensions to update:

Details

SubjectRepoBranchLines +/-
Hard deprecate the `DiffViewHeader` hookmediawiki/coremaster+2 -2
Hooks: Update to use `DifferenceEngineViewHeader`mediawiki/extensions/MobileFrontendmaster+6 -11
Hooks: Update to use `DifferenceEngineViewHeader`mediawiki/extensions/FlaggedRevsmaster+5 -8
Hooks: Update to use `DifferenceEngineViewHeader`mediawiki/extensions/VisualEditormaster+3 -9
Hooks: Update to use `DifferenceEngineViewHeader`mediawiki/extensions/Thanksmaster+4 -6
Update hooks to use `DifferenceEngineViewHeader`, require MW 1.35+mediawiki/extensions/RevisionSlidermaster+17 -13
Add new `DifferenceEngineViewHeader` hook to replace `DiffViewHeader`mediawiki/coremaster+36 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 18 2020, 1:20 PM
DannyS712 created this task.
DannyS712 moved this task from Untriaged to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.
gerritbot added a comment.Jun 18 2020, 1:20 PM

Change 606429 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add new DifferenceEngineViewHeader hook to replace DiffViewHeader

https://gerrit.wikimedia.org/r/606429

gerritbot added a project: Patch-For-Review.Jun 18 2020, 1:20 PM
DannyS712 mentioned this in T249434: Replace hooks using Revision objects with RevisionRecord.Jun 18 2020, 1:26 PM
gerritbot added a comment.Jun 24 2020, 12:12 AM

Change 606429 merged by jenkins-bot:
[mediawiki/core@master] Add new DifferenceEngineViewHeader hook to replace DiffViewHeader

https://gerrit.wikimedia.org/r/606429

DannyS712 added projects: MediaWiki-extensions-FlaggedRevs, MobileFrontend, Revision-Slider, Thanks, VisualEditor.Jun 24 2020, 12:33 AM
DannyS712 updated the task description. (Show Details)
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 24 2020, 12:33 AM
gerritbot added a comment.Jun 24 2020, 12:36 AM

Change 607386 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607386

gerritbot added a comment.Jun 24 2020, 12:39 AM

Change 607387 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607387

gerritbot added a comment.Jun 24 2020, 12:41 AM

Change 607388 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607388

gerritbot added a comment.Jun 24 2020, 12:43 AM

Change 607390 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/VisualEditor@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607390

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.39; 2020-06-30).Jun 24 2020, 1:00 AM
gerritbot added a comment.Jun 24 2020, 1:02 AM

Change 607393 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/RevisionSlider@master] Update hooks to use DifferenceEngineViewHeader, require MW 1.35+

https://gerrit.wikimedia.org/r/607393

DannyS712 updated the task description. (Show Details)Jun 24 2020, 1:08 AM
gerritbot added a comment.Jun 24 2020, 5:54 PM

Change 607393 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Update hooks to use DifferenceEngineViewHeader, require MW 1.35+

https://gerrit.wikimedia.org/r/607393

gerritbot added a comment.Jun 24 2020, 6:07 PM

Change 607386 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607386

gerritbot added a comment.Jun 24 2020, 6:07 PM

Change 607387 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607387

gerritbot added a comment.Jun 24 2020, 6:08 PM

Change 607388 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607388

gerritbot added a comment.Jun 24 2020, 6:08 PM

Change 607390 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607390

gerritbot added a comment.Jun 24 2020, 6:09 PM

Change 607581 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the DiffViewHeader hook

https://gerrit.wikimedia.org/r/607581

DannyS712 updated the task description. (Show Details)Jun 24 2020, 6:10 PM
DannyS712 moved this task from In progress to Awaiting review and deployment on the User-DannyS712 board.
gerritbot added a comment.Jun 24 2020, 6:50 PM

Change 607581 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the DiffViewHeader hook

https://gerrit.wikimedia.org/r/607581

Maintenance_bot removed a project: Patch-For-Review.Jun 24 2020, 7:11 PM
DannyS712 closed this task as Resolved.Jun 24 2020, 10:11 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 24 2020, 10:11 PM
DannyS712 moved this task from Awaiting review and deployment to Resolved (deprecation) on the User-DannyS712 board.Jul 9 2020, 11:13 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL