Page MenuHomePhabricator

Replace `DiffViewHeader` hook with one that doesn't use Revision objects
Closed, ResolvedPublic

Description

Currently, the DiffViewHeader hook's second and third parameters are Revision objects (or null). These can be replaced with RevisionRecord objects. However, those RevisionRecord objects correspond to the return values of the DifferenceEngine's (first hook parameter) getOldRevision and getNewRevision, so really the replacement only needs to pass a DifferenceEngine

New name: DifferenceEngineViewHeader (to match DifferenceEngineOldHeaderNoOldRev)

Deployed extensions to update:

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 18 2020, 1:20 PM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 606429 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Add new DifferenceEngineViewHeader hook to replace DiffViewHeader

https://gerrit.wikimedia.org/r/606429

Change 606429 merged by jenkins-bot:
[mediawiki/core@master] Add new DifferenceEngineViewHeader hook to replace DiffViewHeader

https://gerrit.wikimedia.org/r/606429

Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 24 2020, 12:33 AM

Change 607386 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/FlaggedRevs@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607386

Change 607387 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/MobileFrontend@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607387

Change 607388 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/Thanks@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607388

Change 607390 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/VisualEditor@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607390

Change 607393 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/extensions/RevisionSlider@master] Update hooks to use DifferenceEngineViewHeader, require MW 1.35+

https://gerrit.wikimedia.org/r/607393

DannyS712 updated the task description. (Show Details)Jun 24 2020, 1:08 AM

Change 607393 merged by jenkins-bot:
[mediawiki/extensions/RevisionSlider@master] Update hooks to use DifferenceEngineViewHeader, require MW 1.35+

https://gerrit.wikimedia.org/r/607393

Change 607386 merged by jenkins-bot:
[mediawiki/extensions/FlaggedRevs@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607386

Change 607387 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607387

Change 607388 merged by jenkins-bot:
[mediawiki/extensions/Thanks@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607388

Change 607390 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Hooks: Update to use DifferenceEngineViewHeader

https://gerrit.wikimedia.org/r/607390

Change 607581 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] Hard deprecate the DiffViewHeader hook

https://gerrit.wikimedia.org/r/607581

DannyS712 updated the task description. (Show Details)Jun 24 2020, 6:10 PM

Change 607581 merged by jenkins-bot:
[mediawiki/core@master] Hard deprecate the DiffViewHeader hook

https://gerrit.wikimedia.org/r/607581

DannyS712 closed this task as Resolved.Jun 24 2020, 10:11 PM
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJun 24 2020, 10:11 PM