Page MenuHomePhabricator

[Bug] mobile-html: Too many sections collapsed on some articles
Closed, ResolvedPublic

Description

Steps to Reproduce

  1. Open https://en.wikipedia.org/api/rest_v1/page/mobile-html/2018_FIFA_World_Cup or http://localhost:8888/en.wikipedia.org/v1/page/mobile-html/2018_FIFA_World_Cup
  2. Scroll down to the Group Stage Section

Expected Results

Section isn't collapsed

Actual Results

Section is collapsed

Event Timeline

JoeWalsh created this task.Jun 18 2020, 4:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2020, 4:00 PM
JoeWalsh triaged this task as Medium priority.Jun 18 2020, 4:00 PM

Change 606461 had a related patch set uploaded (by Joewalsh; owner: Joewalsh):
[mediawiki/services/mobileapps@master] Only reference lists without a group should be considered reference sections

https://gerrit.wikimedia.org/r/606461

JoeWalsh added subscribers: Charlotte, JMinor.EditedJun 22 2020, 5:11 PM

@JMinor @Charlotte this fix would mean if a notes section precedes the main reference section, it wouldn't be collapsed. For example, in https://en.wikipedia.org/api/rest_v1/page/mobile-html/United_States "Notes" would no longer be collapsed and "References" would be the first collapsed section. Could you both confirm you're OK with this tradeoff?

@JMinor @Charlotte this fix would mean if a notes section precedes the main reference section, it wouldn't be collapsed. For example, in https://en.wikipedia.org/api/rest_v1/page/mobile-html/United_States "Notes" would no longer be collapsed and "References" would be the first collapsed section. Could you both confirm you're OK with this tradeoff?

I'm fine with it.

Change 606461 merged by jenkins-bot:
[mediawiki/services/mobileapps@master] Only reference lists without a group should be considered reference sections

https://gerrit.wikimedia.org/r/606461

MSantos closed this task as Resolved.Wed, Jul 8, 12:01 PM