Page MenuHomePhabricator

Separate federated properties test cases into their own test classes
Closed, ResolvedPublic3 Estimated Story Points

Description

CI always runs with the default settings, so for testing in the local envioronment, it is not an option to use a modified LocalSettings.php.

Thus if needed, integration tests that require $wgWBRepoSettings['federatedPropertiesEnabled'] = true should do so for the entire class in the setup() method. Mixing test cases in a single class, so that federatedPropertiesEnabled is false for most tests, but true for some others, will eventually lead to confusion and possibly failing CI tests.

To be done

Event Timeline

Change 612365 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: Refactor test dirs / testcase usage

https://gerrit.wikimedia.org/r/612365

Change 612365 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Refactor test dirs / testcase usage

https://gerrit.wikimedia.org/r/612365

Addshore added a subscriber: Addshore.

Resolved as it's in the Done column at the end of sprint 3 (start of sprint 4)