Page MenuHomePhabricator

Monobook search button searchGoButton should have consistent ID.
Closed, ResolvedPublic

Description

The ID searchGoButton is used for the go button in Monobook. In Vector this same element has the ID searchButton. I'd like to consolidate the data generating Monobook and Vector.

Users can prepare for this change by using the selector
#searchGoButton, #searchButton instead of #searchGoButton

According to https://global-search.toolforge.org/?q=searchGoButton&namespaces=&title= 728 pages would be impacted.

Changing this would require the following:

  • Fix Wikibase to support both IDs (code)
  • Preparing editors for the change via a user notice T255953
  • Renaming searchGoButton to searchButton in Modern
  • Renaming searchGoButton to searchButton in Monobook

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 18 2020, 4:36 PM
Mainframe98 updated the task description. (Show Details)Jun 18 2020, 5:20 PM
Ammarpad triaged this task as Medium priority.

So, the plan is to replace #searchGoButton with #searchButton, to match Vector? If that goes forward, can I suggest renaming the search button id as well? If not, that would mean monobook and modern would have #searchButton and #mw-searchButton, which is surely rather confusing.

not, that would mean monobook and modern would have #searchButton and #mw-searchButton, which is surely rather confusing.

Vector also has #mw-searchButton and #searchButton (in Vector the #searchButton element is hidden)

My thinking with targeting this selector first was that less pages would need to migrate. 6,399 pages use #searchButton at current time compared to the 448 in T255953.

Note there is also discussion in T42622 around the UI confusion of having two buttons, so it might be a more worthwhile expenditure of our energy revisiting having that 2nd button at all. For now at least I'd like all skins to use the same markup, whether that markup is good or bad.

Jdlrobson changed the task status from Open to Stalled.Jun 29 2020, 11:32 PM
Aklapper changed the task status from Stalled to Open.Fri, Jul 24, 10:11 AM

Resetting task status to open as that day has passed.

Change 616190 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Wikibase@master] Replace #searchGoButton selector with #searchButton

https://gerrit.wikimedia.org/r/616190

Change 616191 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MonoBook@master] MonoBook: Rename searchGoButton -> searchButton

https://gerrit.wikimedia.org/r/616191

Change 616191 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] MonoBook: Rename searchGoButton -> searchButton

https://gerrit.wikimedia.org/r/616191

Change 616190 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace #searchGoButton selector with #searchButton

https://gerrit.wikimedia.org/r/616190

Jdlrobson closed this task as Resolved.Mon, Jul 27, 8:28 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)

I've requested this is mentioned in tech news in T255791.

Change 617687 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MonoBook@master] Rename #searchGoButton -> #searchButton (2)

https://gerrit.wikimedia.org/r/617687

Change 617687 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Rename #searchGoButton -> #searchButton (2)

https://gerrit.wikimedia.org/r/617687

Jdlrobson closed this task as Resolved.Fri, Jul 31, 3:10 PM