The ID searchGoButton is used for the go button in Monobook. In Vector this same element has the ID searchButton. I'd like to consolidate the data generating Monobook and Vector.
Users can prepare for this change by using the selector
#searchGoButton, #searchButton instead of #searchGoButton
According to https://global-search.toolforge.org/?q=searchGoButton&namespaces=&title= 728 pages would be impacted.
Changing this would require the following:
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Ammarpad | T255791 Monobook search button searchGoButton should have consistent ID. | |||
| Resolved | Jdlrobson | T255953 Update site scripts and styles for Modern and Monobook: #searchGoButton -> #searchButton |
So, the plan is to replace #searchGoButton with #searchButton, to match Vector? If that goes forward, can I suggest renaming the search button id as well? If not, that would mean monobook and modern would have #searchButton and #mw-searchButton, which is surely rather confusing.
not, that would mean monobook and modern would have #searchButton and #mw-searchButton, which is surely rather confusing.
Vector also has #mw-searchButton and #searchButton (in Vector the #searchButton element is hidden)
My thinking with targeting this selector first was that less pages would need to migrate. 6,399 pages use #searchButton at current time compared to the 448 in T255953.
Note there is also discussion in T42622 around the UI confusion of having two buttons, so it might be a more worthwhile expenditure of our energy revisiting having that 2nd button at all. For now at least I'd like all skins to use the same markup, whether that markup is good or bad.
Change 616190 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/extensions/Wikibase@master] Replace #searchGoButton selector with #searchButton
Change 616191 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MonoBook@master] MonoBook: Rename searchGoButton -> searchButton
Change 616191 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] MonoBook: Rename searchGoButton -> searchButton
Change 616190 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Replace #searchGoButton selector with #searchButton
I was surprised to see there is still one case in Monobook here so reopening:
https://gerrit.wikimedia.org/g/mediawiki/skins/MonoBook/+/058fef6bf6d549d5023afc9030788ff95c7f8106/resources/screen-desktop.css#106
Change 617687 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MonoBook@master] Rename #searchGoButton -> #searchButton (2)
Change 617687 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] Rename #searchGoButton -> #searchButton (2)