Page MenuHomePhabricator

Newcomer tasks: Post-edit dialog suggested edit card is missing the wikidata description
Closed, InvalidPublic

Assigned To
None
Authored By
RHo
Jun 18 2020, 7:57 PM
Referenced Files
F31908132: image.png
Jun 26 2020, 9:47 PM
F31905869: image.png
Jun 25 2020, 10:08 PM
F31870692: image.png
Jun 18 2020, 7:57 PM
F31870712: image.png
Jun 18 2020, 7:57 PM
F31870707: image.png
Jun 18 2020, 7:57 PM
F31870694: image.png
Jun 18 2020, 7:57 PM

Description

Actual desktop
image.png (449×564 px, 64 KB)
Expected desktop
image.png (300×500 px, 47 KB)
Actual mobile
image.png (224×682 px, 17 KB)
Expected mobile
image.png (640×360 px, 58 KB)

The wikidata description from the design is not shown in the card.

It should appear with 4px space after the article title and overflow into an ellipsis after 1 line
(the article title should be able to overflow to 2 lines max.)

Event Timeline

Tgr subscribed.

Articles on our test sites are not linked to Wikidata. Sorry, I should have mentioned on the post-edit task that this part is hard to test. You could set something up manually (there's test.wikidata.org for testwiki and wikidata.beta.wmflabs.org for the beta sites) but the easier approach is to test the post-edit dialog in production without actually making an edit, by clicking through a suggested edit card and then typing this in the browser console:

mw.config.get( 'ge-suggestededit-session' ).postEditDialogNeedsToBeShown = true;
mw.config.get( 'ge-suggestededit-session' ).maybeShowPostEditDialog();

@Tgr -- I just went and made a suggested edit in my personal account on Czech Wikipedia, and I noticed that the dialog did not have a Wikidata description. Is that because the topic is not in Wikidata?

image.png (661×1 px, 117 KB)

Probably (not linked to a WD item or the item does not have a description in Czech - I'd expect the former to be rare, the latter to be not so rare). Or maybe there's a non-deterministic bug. I can see the Wikidata description some of the time on cswiki, at least.

Marshall asked me to test this out, and I did a test edit from SE, and I see this:

image.png (505×636 px, 39 KB)

According to the task's description, I believe that's expected.

I've checked the case Marshall has, and the cause seems to be missing Wikidata description - that's actually quite common :-).

I assume we can keep this closed?