Page MenuHomePhabricator

DerivedPageDataUpdater::prepareUpdate $options array can include Revision objects
Closed, ResolvedPublic

Description

Passing a Revision should be hard deprecated.
All direct callers are in core, but those pass on any options they got, and so hard deprecation needs to occur there as well

Event Timeline

DannyS712 triaged this task as Medium priority.Jun 20 2020, 9:46 AM
DannyS712 created this task.
DannyS712 moved this task from Unsorted to In progress on the User-DannyS712 board.

Change 606771 had a related patch set uploaded (by DannyS712; owner: DannyS712):
[mediawiki/core@master] DerivedPageDataUpdater::prepareUpdate deprecate passing a Revision

https://gerrit.wikimedia.org/r/606771

Hmm, no callers specify an oldrevision anywhere: https://codesearch.wmflabs.org/search/?q=%5B%27%22%5Doldrevision%5B%27%22%5D&i=fosho&files=%5C.php%24&repos=
Not sure why the option is needed at all, but regardless, pretty easy to deprecate using a Revision object

Change 606771 merged by jenkins-bot:
[mediawiki/core@master] DerivedPageDataUpdater::prepareUpdate deprecate passing a Revision

https://gerrit.wikimedia.org/r/606771

DannyS712 closed this task as Resolved.Jun 24 2020, 3:17 AM
DannyS712 removed a project: Patch-For-Review.