Document tagline and icon options of $wgLogos by putting them in the installer
Closed, ResolvedPublic
Actions

Description

T249047: [Site Config] Make new logos available in production in preparation for T246170 added taglines and icons to the $wgLogos definition, apparently so that $wgMobileFrontendLogo could be removed (T248500). The problem is that these new keys are not documented anywhere!

From the associated commits rOMWC9065650029e45f02438a90e306c0837b82f4019b and rOMWCb8b051fee1b85522b9002dc5b2c618e37b8977f1, I can derive that icon links to an image file, and that tagline defines an <img> specification, with a src, width and height attribute. What they're actually for is not mentioned.

Definition of Done

DefaultSettings.php mentions the new keys
The release notes section on $wgLogos mentions the new keys
Documentation on MediaWiki specifies a description of the keys, the kind of image they expect and when they should be used
Installer takes into account the new keys

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+309 -32	Update installer to reflect modern logos
	mediawiki/core	master	+43 -2	Add support in installer for other logo keys

Customize query in gerrit

Related Objects

Mentioned In: T318753: Installer encourages users to drag and drop a PNG instead of using hosted links
T301527: Consider making Vector 2022 the default skin for MediaWiki 1.41
T252850: [Vector legacy ]Fix a tagline's small font on the logos of some projects
T247790: wgLogos follow up work
T252580: Document logo creation guidelines in MediaWiki
Mentioned Here: T248500: Replace $wgMobileFrontendLogo with $wgLogos
T249047: [Site Config] Make new logos available in production in preparation for T246170
rOMWCb8b051fee1b8: Preparation for removal of $wgMobileFrontendLogo
rOMWC9065650029e4: Add project taglines

Event Timeline

Mainframe98 created this task.Jun 20 2020, 2:10 PM

Izno added a project: MediaWiki-Documentation.Jun 20 2020, 2:30 PM

Mainframe98 updated the task description. (Show Details)Jun 20 2020, 2:41 PM

Mainframe98 mentioned this in T252580: Document logo creation guidelines in MediaWiki.Jul 25 2020, 10:55 AM

Does not seem like a release blocker. Nothing suggests or implies that these need to be used, so 1.35 works fine without it as well. It can be publicly launched in 1.36 instead.

Change 612437 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/core@master] Add support in installer for other logo keys

https://gerrit.wikimedia.org/r/612437

gerritbot added a project: Patch-For-Review.Jul 29 2020, 1:06 AM

(https://www.mediawiki.org/wiki/Manual:$wgLogos does document this now)

Krinkle mentioned this in T247790: wgLogos follow up work.Jul 29 2020, 2:45 AM

Jdforrester-WMF added a subscriber: Jdforrester-WMF.Jul 29 2020, 9:02 AM

• Jdlrobson renamed this task from Document tagline and icon options of $wgLogos to Document tagline and icon options of $wgLogos by putting them in the installer.Jul 29 2020, 3:24 PM

Change 612437 abandoned by Jdlrobson:
[mediawiki/core@master] Add support in installer for other logo keys

Reason:
Not a priority of mine right now (I may resurrect this patch nearer to the 1.36 release). Somebody should feel free to fork this in the mean time if they feel inspired!

https://gerrit.wikimedia.org/r/612437

Hey there, should this be moved to 1.37? The cut for 1.36 has happened, and 1.36.0-rc.0 will be cut in a fortnight or so, after which feature changes shouldn't be landed and back-ported.

Maintenance_bot removed a project: Patch-For-Review.Apr 10 2021, 11:10 PM

Jdforrester-WMF added a project: MediaWiki-Installer.Apr 15 2021, 6:24 PM

Reedy added a project: Readers-Web-Backlog.Apr 15 2021, 6:27 PM

Reedy updated the task description. (Show Details)

• Jdlrobson edited projects, added MW-1.37-release; removed MW-1.36-release.Apr 20 2021, 2:35 PM

• Jdlrobson assigned this task to ovasileva.Apr 20 2021, 7:02 PM

• Jdlrobson moved this task from Incoming to Needs Prioritization on the Readers-Web-Backlog board.

Skins are still transitioning and since Modern Vector is not yet the default skin for an installed MediaWiki instance I think this can wait until 1.37 and when Desktop improvements has rolled out to at least 50% of Wikimedia wikis.

ovasileva moved this task from Needs Prioritization to Triaged but Future on the Readers-Web-Backlog board.Apr 27 2021, 4:22 PM

• Jdlrobson moved this task from Triaged but Future to Tracking on the Readers-Web-Backlog board.Jun 14 2021, 6:22 PM

• Jdlrobson edited projects, added Readers-Web-Backlog (Tracking); removed Readers-Web-Backlog.

• Jdlrobson added a project: MediaWiki-Core-Skin-Architecture.

• Jdlrobson moved this task from Backlog to It's complicated on the MediaWiki-Core-Skin-Architecture board.Jun 15 2021, 9:10 PM

• Jdlrobson moved this task from It's complicated to Logos and associated config on the MediaWiki-Core-Skin-Architecture board.Jul 13 2021, 11:56 PM