[EPIC] SkinMustache::getTemplateData should return data common to all skins
Closed, ResolvedPublic
Actions

Description

The SkinMustache::getTemplateData should return a flexible array of template data that can be used to render all the existing Wikimedia deployed skins.

The Vector skin is currently being built out with flexible data in mind and it's expected that once the data required to render Vector is stable we will upstream it to core to the SkinMustache class so other skins can benefit

acceptance criteria

search
Indicators
afterContentHook ('html-dataAfterContent' => $this->afterContentHook())
Sitenotice 'html-sitenotice' => $this->getSiteNotice(),
Language attributes 'html-userlangattributes' => $this->prepareUserLanguageAttributes(),
T256927
Menu data
footer data

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+94 -6	Expose portlet data in SkinMustache
	mediawiki/core	master	+12 -7	Add more data items to SkinMustache::getTemplateData

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ammarpad	T255924 [EPIC] SkinMustache::getTemplateData should return data common to all skins
		Resolved		Ammarpad	T256927 Deprecate Skin::generateDebugHTML

Event Timeline

Jdlrobson created this task.Jun 20 2020, 7:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 20 2020, 7:12 PM

Jdlrobson updated the task description. (Show Details)Jun 29 2020, 11:21 PM

Jdlrobson renamed this task from SkinMustache::getTemplateData should return data common to all skins to [EPIC] SkinMustache::getTemplateData should return data common to all skins.Jun 29 2020, 11:25 PM

Jdlrobson triaged this task as High priority.

Jdlrobson mentioned this in T248752: [EPIC] Standardise template data across MediaWiki skins.

Jdlrobson added a project: patch-welcome.Jul 1 2020, 10:26 PM

Jdlrobson updated the task description. (Show Details)

Jdlrobson updated the task description. (Show Details)Jul 1 2020, 10:33 PM

Ammarpad claimed this task.Jul 4 2020, 6:38 AM

Jdlrobson closed subtask T256927: Deprecate Skin::generateDebugHTML as Resolved.Jul 6 2020, 6:26 PM

Change 610294 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Add more data items to SkinMustache::getTemplateData

https://gerrit.wikimedia.org/r/610294

gerritbot added a project: Patch-For-Review.Jul 8 2020, 2:09 PM

Jdlrobson mentioned this in T256083: Minerva skin should use the SkinMustache class.Jul 9 2020, 3:59 PM

Change 610294 merged by jenkins-bot:
[mediawiki/core@master] Add more data items to SkinMustache::getTemplateData

https://gerrit.wikimedia.org/r/610294

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 9 2020, 5:00 PM

Jdlrobson updated the task description. (Show Details)Jul 9 2020, 5:05 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 9 2020, 5:10 PM

Ammarpad updated the task description. (Show Details)Jul 10 2020, 2:56 PM

I think menu data is going to be a little trickier and will make a task. Putting this on hold until I have more of an actionable here.

Change 624899 had a related patch set uploaded (by Ammarpad; owner: Jdlrobson):
[mediawiki/core@master] Expose portlet data in SkinMustache

https://gerrit.wikimedia.org/r/624899

gerritbot added a project: Patch-For-Review.Sep 18 2020, 12:19 PM

Ammarpad changed the task status from Stalled to Open.Sep 18 2020, 12:19 PM

Change 624899 merged by jenkins-bot:
[mediawiki/core@master] Expose portlet data in SkinMustache

https://gerrit.wikimedia.org/r/624899

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2020, 2:10 AM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.11; 2020-09-29).Sep 23 2020, 3:00 AM

The spec is looking pretty complete - yay!

[EPIC] SkinMustache::getTemplateData should return data common to all skinsClosed, ResolvedPublicActions