Page MenuHomePhabricator

The line does not return to its original position after hiding the list on wikipedia.org
Closed, ResolvedPublicDesign

Description

Visit https://www.wikipedia.org/
After you click on the 'Read Wikipedia on your languages' button and open the list, the line near the button expands. When hiding the list, the line remains in the same position, although it should be narrowed.

Win10, Google Chrome.

Current

image.png (160×1 px, 8 KB)

Expected

image.png (174×1 px, 9 KB)

Cause

Interesting browser bug:
When the list is closed .lang-list-active .lang-list-border { max-width: 85%; } rule is unapplied, but the original .lang-list-border { max-width: 460px; } rule does not take effect / restrict the width.

Solution (workaround)

Replace max-width: 85%; with max-width: unset;

Related Objects

Event Timeline

Demian updated the task description. (Show Details)
Demian subscribed.

It's a browser bug, but there is an easy workaround: replace .lang-list-active .lang-list-border { max-width: 85%; } with max-width: unset;

Change 606809 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[wikimedia/portals@master] Language list border line should return to narrow state after language list is closed

https://gerrit.wikimedia.org/r/606809

[Resetting assignee due to inactive user account]

Change 671192 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[wikimedia/portals@master] The line does not return to its original position after hiding the list

https://gerrit.wikimedia.org/r/671192

I gone through this issue deeply...this actually not a browser bug...
this is human typo error.
Because time delay was set 400s which was very much....
I have fixed the issue.
Please check this out

I gone through this issue deeply...this actually not a browser bug...
this is human typo error.
Because time delay was set 400s which was very much....
I have fixed the issue.
Please check this out

Yes, in my opinion the problem has been fixed! All the same, there is no smoothness, but that's another task. Thank :)

Yes, in my opinion the problem has been fixed! All the same, there is no smoothness, but that's another task. Thank :)

If you want i can try to add smoothness...
what exactly do you want in smoothness if you will create a issue for it
i feel happy to work on it.
Thanks:)

Yes, in my opinion the problem has been fixed! All the same, there is no smoothness, but that's another task. Thank :)

If you want i can try to add smoothness...
what exactly do you want in smoothness if you will create a issue for it
i feel happy to work on it.
Thanks:)

It seems to me that the border disappears very abruptly. Compared to the appearance of a border. Perhaps disappearing should be started before the menu closes.

Yes, in my opinion the problem has been fixed! All the same, there is no smoothness, but that's another task. Thank :)

If you want i can try to add smoothness...
what exactly do you want in smoothness if you will create a issue for it
i feel happy to work on it.
Thanks:)

It seems to me that the border disappears very abruptly. Compared to the appearance of a border. Perhaps disappearing should be started before the menu closes.

ok i will create new task for this issue and try to fix asap....:)

Change 671631 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[wikimedia/portals@master] Merge branch 'master' of https://gerrit.wikimedia.org/r/a/wikimedia/portals into T255929 Change-Id: I9ea3d8fbdb3176e73d680b968a617c6679299241

https://gerrit.wikimedia.org/r/671631

Change 671631 abandoned by Bharatkhatri:
[wikimedia/portals@master] Merge branch 'master' of https://gerrit.wikimedia.org/r/a/wikimedia/portals into T255929 Change-Id: I9ea3d8fbdb3176e73d680b968a617c6679299241

Reason:
By mistakely created..please ignore this commit...

https://gerrit.wikimedia.org/r/671631

Change 671192 merged by jenkins-bot:
[wikimedia/portals@master] The line does not return to its original position after hiding the list

https://gerrit.wikimedia.org/r/671192