Page MenuHomePhabricator

Remove shouldPreloadLogo from Skin.php
Closed, ResolvedPublic

Description

@deprecated since 1.32. It's Redundant. I believe it's existence in the already large Skin class causes unnecessary confusion.

No known skins rely on its parent, so I suggest at this point we just remove it from Skin.php in core.

https://codesearch.wmflabs.org/search/?q=shouldPreloadLogo&i=nope&files=&repos=

Event Timeline

Change 606975 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/core@master] Remove deprecated Skin::shouldPreloadLogo

https://gerrit.wikimedia.org/r/606975

Change 606975 merged by jenkins-bot:
[mediawiki/core@master] Remove deprecated Skin::shouldPreloadLogo

https://gerrit.wikimedia.org/r/606975

Jdlrobson claimed this task.