https://gerrit-test.wikimedia.org/r/ loads content from third-party https://fonts.gstatic.com/ via https://gerrit-test.wikimedia.org/r/styles/fonts.css
Regression in Gerrit 3.2 caused by https://gerrit-review.googlesource.com/c/gerrit/+/255560
Upstream issue | https://bugs.chromium.org/p/gerrit/issues/detail?id=12980
Upstream fix for Gerrit 3.2 itself | https://gerrit-review.googlesource.com/c/gerrit/+/273371
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | QChris | T186406 Polygerrit Outgoing reviews, Incoming reviews and Recently closed headings should be more different from commits | |||
| Resolved | None | T220801 PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+) | |||
| Resolved | QChris | T206453 Big empty space under patch description | |||
| Restricted Task | |||||
| Resolved | None | T210515 context links in diff don't use pointer cursor | |||
| Resolved | Paladox | T223278 "Server error: line 1:33 no viable alternative at character '['" when visiting particular patch | |||
| Restricted Task | |||||
| Resolved | hashar | T103990 Gerrit upload-pack send ALL references causing massive network I/O on common operations | |||
| Resolved | None | T195280 New Gerrit UI does not contain copyable Change-Id or parent commit id | |||
| Declined | Feature | None | T201246 Make a PolyGerrit plugin to welcome new users | ||
| Resolved | QChris | T254158 Gerrit 3.2 upgrade | |||
| Resolved | BUG REPORT | QChris | T255977 Gerrit 3.x test instance loads content from third-party website fonts.gstatic.com |
That was an issue in Gerrit filed as https://bugs.chromium.org/p/gerrit/issues/detail?id=3985 and fixed by Gerrit 2.13 5eb59e374ecd36fd835bb484c13e163fdbe9fa71
Eventually 3.2.0 had 7f77168c3df5339ea4800ecff41b21df16aed6d1 ( https://gerrit-review.googlesource.com/c/gerrit/+/255560 ) which while still referring to a local copy of the font, also adds a fallback to fonts.gstatic.com:
/* latin-ext */
@font-face {
font-family: 'Roboto';
font-style: normal;
font-weight: 400;
- src: local('Roboto'), local('Roboto-Regular'),
- url('../fonts/Roboto-Regular.woff2') format('woff2'),
- url('../fonts/Roboto-Regular.woff') format('woff');
- unicode-range: U+0100-024F, U+1E00-1EFF, U+20A0-20AB, U+20AD-20CF, U+2C60-2C7F, U+A720-A7FF;
+ font-display: swap;
+ src: local('Roboto'), local('Roboto-Regular'), url(https://fonts.gstatic.com/s/roboto/v20/KFOmCnqEu92Fr1Mu7GxKKTU1Kvnz.woff2) format('woff2');
+ unicode-range: U+0100-024F, U+0259, U+1E00-1EFF, U+2020, U+20A0-20AB, U+20AD-20CF, U+2113, U+2C60-2C7F, U+A720-A7FF;
}When previously we had something using the browser font and fallback to Gerrit served files:
@font-face { src: local('Roboto'), local('Roboto-Regular'), url('../fonts/Roboto-Regular.woff2') format('woff2'), url('../fonts/Roboto-Regular.woff') format('woff');
We now have a fallback to fonts.gstatic.com:
src: local('Roboto'), local('Roboto-Regular'), url(https://fonts.gstatic.com/s/roboto/v20/KFOmCnqEu92Fr1Mu7GxKKTU1Kvnz.woff2) format('woff2');
Which is a regression in Gerrit 3.2 worth filing a bug to them.
Filed upstream as https://bugs.chromium.org/p/gerrit/issues/detail?id=12980 and that automatically subscribed the commit author @ google ;]
@Paladox said that the gitiles plugin might also load fonts externally. That's still to investigate.
@QChris seems that task is closed as resolved and fixed PolyGerrit. It doesn't fix gitiles, see https://github.com/GerritCodeReview/gitiles/blob/master/resources/com/google/gitiles/static/base.css#L19