Page MenuHomePhabricator
Create Task
Maniphest T256007

AddWiki.php wrongly uses 127.0.0.1 instead of a system account
Closed, ResolvedPublic
Actions

Description

Per https://shn.wiktionary.org/wiki/Special:Contributions/127.0.0.1, 127.0.0.1 was used rather than a system account like Mediawiki Maintenance.

It probably should

Details

SubjectRepoBranchLines +/-
Use WikiPage::doUserEditContent() instead of ::doEditContent()mediawiki/extensions/WikimediaMaintenancemaster+13 -5
Customize query in gerrit

Related Objects
Search...

Event Timeline

RhinosF1 created this task.Jun 22 2020, 2:59 PM
Restricted Application added a project: User-Urbanecm. · View Herald TranscriptJun 22 2020, 2:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
taavi added a project: MediaWiki-extensions-WikimediaMaintenance.Jun 22 2020, 3:00 PM
DannyS712 added a parent task: T255507: WikiPage::doEditContent falls back to $wgUser.Jun 22 2020, 3:00 PM
RhinosF1 added a subscriber: DannyS712.Jun 22 2020, 3:01 PM

Caused by T255507: WikiPage::doEditContent falls back to $wgUser according to @DannyS712

DannyS712 added a comment.Jun 22 2020, 3:02 PM
In T256007#6244783, @RhinosF1 wrote:

Caused by T255507: WikiPage::doEditContent falls back to $wgUser according to @DannyS712

...hence added as a parent task

Urbanecm removed projects: Wiki-Setup (Create), User-Urbanecm.Jun 22 2020, 6:00 PM
Krinkle renamed this task from AddWiki.php use 127.0.0.1 instead of a system account to AddWiki.php wrongly uses 127.0.0.1 instead of a system account.Jun 22 2020, 6:13 PM
Krinkle updated the task description. (Show Details)
gerritbot added a comment.Jun 24 2021, 6:06 AM

Change 701270 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/WikimediaMaintenance@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/701270

gerritbot added a project: Patch-For-Review.Jun 24 2021, 6:06 AM
DannyS712 claimed this task.Jun 24 2021, 7:07 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJun 24 2021, 7:07 AM
DannyS712 moved this task from Unsorted to Awaiting review and deployment on the User-DannyS712 board.Jun 24 2021, 7:07 AM
gerritbot added a comment.Jun 28 2021, 2:06 PM

Change 701270 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Use WikiPage::doUserEditContent() instead of ::doEditContent()

https://gerrit.wikimedia.org/r/701270

Maintenance_bot removed a project: Patch-For-Review.Jun 28 2021, 2:10 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.12; 2021-06-28).Jun 28 2021, 3:00 PM
DannyS712 closed this task as Resolved.Jun 28 2021, 10:58 PM
DannyS712 mentioned this in T284450: Create Wikipedia Dagbani.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL