Currently, CachingSiteLinkLookup passes keys (concatenated in getSiteLinksForItem() or getByPageCacheKey()) directly into BagOStuff methods, without using any make*Key() method. This isn’t ideal; it should probably use makeKey(). That said, the impact of this is limited since it looks like CachingSiteLinkLookup is only instantiated with a HashBagOStuff (in DirectSqlStore::getSiteLinkLookup()), so the key isn’t used beyond that one cache instance anyways.

See also T255116 for the investigation that led to the creation of this task.