Page MenuHomePhabricator

Build the wvui-input component for Vue.js search
Closed, ResolvedPublic3 Estimated Story Points

Assigned To
Authored By
Niedzielski
Jun 22 2020, 6:06 PM
Referenced Files
F32438207: image.png
Nov 5 2020, 5:25 PM
F32194626: image.png
Sep 1 2020, 9:43 AM
F32194620: image.png
Sep 1 2020, 9:43 AM
F32194628: image.png
Sep 1 2020, 9:43 AM
F32190176: image.png
Sep 1 2020, 9:43 AM
F32194622: image.png
Sep 1 2020, 9:43 AM
F32194624: image.png
Sep 1 2020, 9:43 AM
F32190225: image.png
Sep 1 2020, 9:43 AM

Description

Description

Referencing T255902 for guidance, build the wvui-input for Vue.js search.

Design requirements

image.png (768×1 px, 148 KB)

Search box + search button

The search box follows OOUI guidelines in terms of styling and interactivity. Please refer to either OOUI or the demo for additional details.

Specs

Note: when the search box is inactive there's a border that wraps around the search box + the search button. It's a bit difficult to show in static mocks so please refer to the interactive demo.

image.png (182×663 px, 18 KB)

States
stateimagenotes
inactive
image.png (32×500 px, 2 KB)
bounding border #A2A9B1
hover search box
image.png (32×500 px, 3 KB)
search button becomes visible (OOUI/"Normal"), search box border darkens (#72777D)
hover search button
image.png (37×508 px, 4 KB)
search button background lightens (#FFFFFF) / text lightens (#404244), search box border initial
active & focus
image.png (54×524 px, 5 KB)
search box border (2px / #3366CC), search icon opacity (1), search box grows 20px wider from the left
has value
image.png (77×525 px, 16 KB)
search box text color #000 / bottom-left corner border radius (0)

Patches

https://github.com/wikimedia/wvui/pull/46
https://github.com/wikimedia/wvui/pull/57
https://github.com/wikimedia/wvui/pull/58
https://github.com/wikimedia/wvui/pull/63

Acceptance criteria

  • All component acceptance criteria in T255902 are covered.
    • input border changes on :hover to darker color #72777d
    • clear uses wrong icon, needs to be "clear" icon, not "close"
    • with "end icon" should be "infoFilled", not "info"

Related Objects

Event Timeline

ovasileva triaged this task as Medium priority.Jul 6 2020, 6:37 PM
ovasileva set the point value for this task to 3.Jul 15 2020, 4:50 PM

@Anribolon, it's my understanding that you're still working on RTL support as part of this task. Is that correct or part of another task?

@Volker_E, please review when you're back! Sorry for the pings in Slack--I forgot you were on vacation!

Some minor issues:

  • input border doesn't change on :hover to darker color #72777d
  • clear uses wrong icon, needs to be "clear" icon, not "close"
  • with "end icon" should be "infoFilled", not "info"

@ovasileva Process: Moving back to doing or filing follow-ups?

@ovasileva Process: Moving back to doing or filing follow-ups?

I think doing should work.

Change 629477 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[wvui@master] [component][input]: Fix CSS output, limit interaction changes to not disabled

https://gerrit.wikimedia.org/r/629477

Change 629477 merged by Niedzielski:
[wvui@master] [component][input]: Fix CSS output, limit interaction changes to not disabled

https://gerrit.wikimedia.org/r/629477

Change 638206 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[wvui@master] [components][input] Use standard 'clear' icon

https://gerrit.wikimedia.org/r/638206

Change 638209 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[wvui@master] [components][icon] Remove font-size property

https://gerrit.wikimedia.org/r/638209

Change 638206 merged by jenkins-bot:
[wvui@master] [components][input] Use standard 'clear' icon

https://gerrit.wikimedia.org/r/638206

Change 638209 merged by jenkins-bot:
[wvui@master] [components][icon] Remove font-size property

https://gerrit.wikimedia.org/r/638209

Moving back once more as Safari needs to be normalized for type=search. That was not done while OOUI does it.

image.png (820×1 px, 380 KB)

True for iOS and macOS.

Change 639610 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[wvui@master] [components][input] Normalize type="search" appearance

https://gerrit.wikimedia.org/r/639610

Change 639610 merged by jenkins-bot:
[wvui@master] [components][input] Normalize type="search" appearance

https://gerrit.wikimedia.org/r/639610

And with the last merged patch we can finally close this as resolved! :)