Page MenuHomePhabricator
Create Task
Maniphest T256063

PageForms: "values dependent on" in PFFormField uses the wrong name
Closed, InvalidPublic
Actions

Description

In the work done in T184251: Upgrade Select2 in Page Forms (was formerly: Upgrade JS libraries included in Page Forms), the target name that should be used for values dependent on was changed, but the the field to set the selector was not updated.

See the introduction of the problem and my fix

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Fix “values dependent on” selectormediawiki/extensions/PageFormsmaster+1 -1
Fix “values dependent on” selectormediawiki/extensions/PageFormsmaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

MarkAHershberger created this task.Jun 22 2020, 9:01 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2020, 9:01 PM
gerritbot added a comment.Jun 22 2020, 9:05 PM

Change 607118 had a related patch set uploaded (by markahershberger; owner: markahershberger):
[mediawiki/extensions/PageForms@master] Fix “values dependent on” selector

https://gerrit.wikimedia.org/r/607118

gerritbot added a project: Patch-For-Review.Jun 22 2020, 9:05 PM
gerritbot added a comment.Jun 23 2020, 5:20 PM

Change 607319 had a related patch set uploaded (by markahershberger; owner: markahershberger):
[mediawiki/extensions/PageForms@master] Fix “values dependent on” selector

https://gerrit.wikimedia.org/r/607319

gerritbot added a comment.Jun 23 2020, 10:12 PM

Change 607118 abandoned by markahershberger:
Fix “values dependent on” selector

https://gerrit.wikimedia.org/r/607118

Yaron_Koren subscribed.Jun 25 2020, 6:22 PM

Do you still want that 2nd patch checked in? I don't understand that change.

Aklapper added a comment.Jul 23 2020, 8:50 PM

@MarkAHershberger: Could you please answer the last comment? Thanks in advance!

Yaron_Koren closed this task as Invalid.Sep 9 2020, 1:05 PM

I'm marking this as "Invalid"... if you still think this is a bug, though, feel free to re-open it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits