Page MenuHomePhabricator

PageForms: "values dependent on" in PFFormField uses the wrong name
Closed, InvalidPublic

Description

In the work done in T184251: Upgrade Select2 in Page Forms (was formerly: Upgrade JS libraries included in Page Forms), the target name that should be used for values dependent on was changed, but the the field to set the selector was not updated.

See the introduction of the problem and my fix

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2020, 9:01 PM

Change 607118 had a related patch set uploaded (by markahershberger; owner: markahershberger):
[mediawiki/extensions/PageForms@master] Fix “values dependent on” selector

https://gerrit.wikimedia.org/r/607118

Change 607319 had a related patch set uploaded (by markahershberger; owner: markahershberger):
[mediawiki/extensions/PageForms@master] Fix “values dependent on” selector

https://gerrit.wikimedia.org/r/607319

Change 607118 abandoned by markahershberger:
Fix “values dependent on” selector

https://gerrit.wikimedia.org/r/607118

Do you still want that 2nd patch checked in? I don't understand that change.

@MarkAHershberger: Could you please answer the last comment? Thanks in advance!

Yaron_Koren closed this task as Invalid.Sep 9 2020, 1:05 PM

I'm marking this as "Invalid"... if you still think this is a bug, though, feel free to re-open it.