From OTRS:
Hi there , how comes I couldn’t find the Amharic language on the app ?
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11409552
cmadeo | |
Jun 22 2020, 9:20 PM |
F31923759: IMG_38A0B031345F-1.jpeg | |
Jul 10 2020, 8:33 PM |
F31923753: IMG_0189.PNG | |
Jul 10 2020, 8:33 PM |
F31923750: IMG_0187.PNG | |
Jul 10 2020, 8:33 PM |
F31923752: IMG_0190.PNG | |
Jul 10 2020, 8:33 PM |
F31923739: IMG_0186.PNG | |
Jul 10 2020, 8:17 PM |
F31923705: IMG_3717.PNG | |
Jul 10 2020, 7:23 PM |
From OTRS:
Hi there , how comes I couldn’t find the Amharic language on the app ?
https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11409552
Looks like we are specifically filtering this out in MWKLanguageLinkController.m with the code comment:
/** * List of unsupported language codes. * * As of iOS 8, the system font doesn't support these languages, e.g. "arc" (Aramaic, Syriac font). [0] * * 0: http://syriaca.org/documentation/view-syriac.html */
We should check to be sure this is is still the case.
iOS (perhaps with version 9) appears to have introduced system font support for Syriac languages. As part of this work, these languages were added in app: Amharic, Aramaic, Gothic, and Tigrinya.
Notes and test steps from Github:
Notes
Removes Amharic, Aramaic, Gothic, and Tigrinya from the list of unsupported languages (thanks Toni for pointing to MWKLanguageLinkController in the ticket). It appears that both iOS 12 and iOS 13 support Syriac text and are able to render these languages correctly*. Lezghian remains in the unsupported list because its native language name rendering in app didn't appear to match the rendering here.
Test Steps
* I do not speak/read any of these languages myself, so I'm basing correctness on if they seem to render similar to the Desktop Wikipedia
@Amire80 happy to know anyone literate in Amharic, Aramaic, Gothic, or Tigrinya who'd be willing to look at the beta app?
@ABorbaWMF this is one of a couple user facing changes for the 6.6.2 hotfix. Please just verify basic rendering of these languages in the feed and article reader, unless you secretly read Amharic, Aramaic, Gothic, or Tigrinya
So far so good. I've found an issue with some infoboxes on Aramaic (screenshot below). I tried with some other RTL languages but I only see it on Aramaic thus far.
Infobox initially appears too far left and the entire infobox can be scrolled left or right
iPhone
I will continue testing.
I don't have an iOS device, but I understand these alphabets well enough to check screenshots. The alphabet in the arcwiki screenshot above looks OK.
Would it be off-topic to also check whether you have N'Ko (nqo) and Santali (sat) in the iOS app? They asked me about it a couple of times.
Would it be off-topic to also check whether you have N'Ko (nqo) and Santali (sat) in the iOS app? They asked me about it a couple of times.
@Amire80 Thanks for bringing that up: the ticket we have for N'Ko https://phabricator.wikimedia.org/T239605 is on this release's board (6.7) and I hope we can get to it. The languages in this ticket were in an unrelated code section.
All of these screenshots look good.
I also fixed a bad edit in Amharic along the way :)