Page MenuHomePhabricator
Create Task
Maniphest T256071

Collection extension should be made aware of the ElectronPdf extension: Settle on a common sidebar key for both extensions
Open, LowPublic
Actions

Description

When running both the Collection and ElectronPdf extension a single menu is used to collate all links by the two extensions

wfLoadExtension('Collection');
wfLoadExtension( 'ElectronPdfService' );

However, if switch the order in LocalSettings.php like so:

wfLoadExtension( 'ElectronPdfService' );
wfLoadExtension('Collection');

I will get two print sections in the sidebar.

Acceptance criteria

  • I'd advise settling on a common sidebar key for both extensions, or duplicating the logic in ElectronPdfService to be aware of Collection extension so that Collection considers ElectronPdfs existence.

Screen Shot 2020-06-22 at 3.16.00 PM.png (370×380 px, 34 KB)

Related Objects

Event Timeline

Jdlrobson created this task.Jun 22 2020, 10:16 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 22 2020, 10:16 PM
Akuckartz awarded a token.Jun 23 2020, 5:59 AM
Jdlrobson mentioned this in T255934: ElectronPDFs should move Printable version link to its own section.Jun 23 2020, 3:43 PM
• Demian subscribed.EditedJun 23 2020, 4:45 PM

I'd advise settling on a common sidebar key for both extensions

I wanted to suggest this solution as well. It's clean, simple and removes the undefined behavior and the branching logic in ElectronPdf. The order of the links in the portlet remain dependent on the load order, but that's only a minor concern, which also applies to other extensions adding links to sidebar portlets - notably the toolbox.

• Demian mentioned this in T254546: Language portlet no longer at the bottom of sidebar.Jun 25 2020, 7:16 AM
Aklapper renamed this task from Collection extension should be made aware of the ElectronPdf extension to Collection extension should be made aware of the ElectronPdf extension: Settle on a common sidebar key for both extensions.Nov 3 2020, 6:20 PM
TheDJ subscribed.Jul 26 2024, 8:14 PM
TheDJ added a comment.Jul 26 2024, 8:57 PM

I agree as well but there are some provenance issues:

  • a common id is/should? generally only used when it is defined in core
  • renaming this will cause the translation strings to move (should check if there are a lot of local overrides of these string perhaps)
TheDJ mentioned this in T371147: Electron/Collection/Proton cleanup.Jul 26 2024, 8:59 PM
Jdlrobson-WMF triaged this task as Low priority.May 23 2025, 11:47 PM
Jdlrobson-WMF moved this task from Backlog to Triaged (PHP) on the Collection board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits