Page MenuHomePhabricator

The closing parenthesis that is part of a signature is not in the right position on talk pages on ar wiki
Closed, InvalidPublic

Description

Steps to replicate:

  1. Go to this page.
  1. Click on any Reply link.

Observe that, the closing parenthesis that is part of the signature RYasmeen_(WMF) is not in the right position.

If you now close the reply tool or post your comment, it will still appear in the same way until you refresh the page.

Screen Shot 2020-06-22 at 5.21.45 PM.png (207×617 px, 48 KB)

Event Timeline

matmarex added a subscriber: matmarex.

This must be a browser bug in Chrome.

  • The problem doesn't occur on Firefox or on IE.
  • I have compared the page DOM before and after opening the reply widget and there are no differences, except for a few invisible elements. I tried removing those manually just in case and that also did not make the issue disappear. The page DOM of the broken and correct rendering are exactly the same.
  • I stepped through the entire reply widget initialization, line by line, and this is the line that causes the problem, in ve.init.mw.Target.js: this.$element.append( surface.$element ); (this is where the visual editing surface is added). So something inside the surface must be causing this; but, removing the surface doesn't make the issue disappear, which is just crazy.
image.png (2×3 px, 734 KB)
image.png (2×3 px, 630 KB)
image.png (2×3 px, 566 KB)

That is a web browser issue (with Chrome, Safari and Brave). Firefox and Chromium don't have this problem. I just checked with these two browsers and the display of the parentheses is correct.

That is a web browser issue (with Chrome, Safari and Brave)...

What I experienced in Safari [i] seems to confirm what @matmarex and @Dyolf77_WMF uncovered.

For the time being, I'm going to de-prioritize this task. If/when we receive reports of this issue affecting peoples' experiences, we can revise its prioritization.

I can't reproduce this any more in Chromium 104. I guess it was fixed in the browser.