Page MenuHomePhabricator

[Regression] The link inspector half opens the first time in every session
Closed, ResolvedPublic

Description

This happens for both VE on any page and inside Reply tool.

Steps to replicate:

  1. Open any page with VE or Reply tool in VE mode.

Observe that the link inspector is half opening.

Screen Shot 2020-06-22 at 5.19.27 PM.png (199×518 px, 16 KB)

Screen Shot 2020-06-22 at 4.41.58 PM.png (362×1 px, 100 KB)

Event Timeline

Hmm, I have not yet been able to reproduce this.

Here's what I did to test...

Beta

Reply tool flow 1

  1. Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats
  2. Open the Reply tool's visual mode
  3. Type + k
4. ✅Observe the link inspector appears as expected:
Screen Shot 2020-06-24 at 9.55.44 AM.png (646×1 px, 92 KB)

Reply tool flow 2

  1. Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Cats
  2. Open the Reply tool's visual mode
  3. Type cats
  4. Highlight what you just typed (cats)
  5. Type + k
6. ✅Observe the link inspector appears as expected:
Screen Shot 2020-06-24 at 9.56.25 AM.png (1×1 px, 249 KB)

Article flow 1

  1. Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Cats
  2. Open the visual editor
  3. Place the cursor within the article w/o any text selected
  4. Type + k
5. ✅Observe the link inspector appears as expected:
Screen Shot 2020-06-22 at 6.31.29 PM.png (538×1 px, 122 KB)

Article flow 2

  1. Visit: https://en.wikipedia.beta.wmflabs.org/wiki/Cats
  2. Open the visual editor
  3. Select some text
  4. Type + k
5. ✅Observe the link inspector appears as expected:
Screen Shot 2020-06-22 at 6.33.34 PM.png (1×1 px, 510 KB)

EDIT: adding correct beta links

@Ryasmeen can you please have a look at the steps I described taking in T256091#6247204 and let me know if there's something I could be doing differently to reproduce the issue you experienced?

It was pretty straightforward. But I think somehow it got fixed now. We can close this.

It was pretty straightforward. But I think somehow it got fixed now. We can close this.

Understood. Closing.

ppelberg claimed this task.