Page MenuHomePhabricator

Uploaded new versions of existing images still appear in SuggestedTags user queues
Open, Needs TriagePublicBUG REPORT

Description

Steps to Reproduce:

  • upload a new version of an existing file
  • wait the required period for the notification/upload to the Vision API

Actual Results:

  • a notification will be sent and the image appears in the User upload tab of SuggestedTags

Expected Results:

  • new versions of existing files should be ignored by Suggested Tags (no appearance in the queue and no notifications sent)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 23 2020, 8:35 PM
Ramsey-WMF updated the task description. (Show Details)Jun 23 2020, 8:38 PM
Ramsey-WMF assigned this task to AnneT.Jun 23 2020, 8:49 PM

such enthusiasm 😄

AnneT added a comment.EditedJun 25 2020, 4:24 PM

@Ramsey-WMF The easiest way to handle this would be to ignore all files with a previous version, which would include the case defined in the task description, and reversions.

  1. Do we want to ignore reversions? I think we do...
  2. This would mean if we decided to fetch annotations for a big batch of existing images in the future for some reason, any image with more than 1 version would be ignored. Is this a possibility that we need to account for?

Change 607861 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Do not include noninitial versions of files in the queue

https://gerrit.wikimedia.org/r/607861

Change 607861 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Ignore new versions of existing files on upload

https://gerrit.wikimedia.org/r/607861

Doesn't seem to be working ☹

Tested this bu uploading a new version of https://commons.wikimedia.org/wiki/File:Setubal-fog.jpg

After the 48 hour period, I got a notification that I had new images to review in my queue.

AnneT added a comment.Aug 6 2020, 6:13 PM

Thanks @Ramsey-WMF, will take a look soon.