Page MenuHomePhabricator

Consolidate places that read/write 'wb_changes' table
Open, Needs TriagePublic

Description

We now have a separate extracted library for handling 'Changes': See: https://github.com/wikimedia/wikibase-changes

This nicely encapsulates much of the business logic for working with changes on both client and repo.

What it does not do is encapsulate the reading and writing of the table that is shared between client and repo.

A number of places are making raw reads to this table (including maintenance scripts): e.g.

  • extensions/Wikibase/client/includes/Store/Sql/BulkSubscriptionUpdater.php
  • extensions/Wikibase/repo/includes/ChangePruner.php
  • etc..

There already exists an store Class that could be used: extensions/Wikibase/lib/includes/Store/Sql/SqlChangeStore.php

Acceptance Criteria:

  • There should be one place that consolidates the code that reads or writes to the changes table (or perhaps two e.g. reading and writing split)
  • This code should be available to both client and repo (e.g. it should be placed in a shared composer library)

Event Timeline

Tarrow renamed this task from Consolidate places that read/write 'wb_changes' to Consolidate places that read/write 'wb_changes' table.Aug 10 2020, 7:50 AM
Tarrow updated the task description. (Show Details)