Use custom UA in GenericActionApiClient including hash of wgServerName
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Addshore
	Jun 24 2020, 10:32 AM

Description

We should grab the domain to use from https://www.mediawiki.org/wiki/Manual:$wgServerName
We should perform some hashing on it https://www.php.net/manual/en/function.hash.php
UA can be injected into GenericActionApiClient and used by the HTTP request factory

Details

	Subject	Repo	Branch	Lines +/-
	FP: Add section about privacy	mediawiki/extensions/Wikibase	master	+4 -0
	FP: GenericActionApiClient sends useragent	mediawiki/extensions/Wikibase	master	+88 -15

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Addshore	T246609 Send user agent w/ federated API requests that includes anonymized unique identifier
		Resolved		• toan	T256226 Use custom UA in GenericActionApiClient including hash of wgServerName

Event Timeline

Addshore created this task.Jun 24 2020, 10:32 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2020, 10:32 AM

Addshore moved this task from Backlog to Ready for Breakdown on the Wikibase - Federated Properties board.Jun 24 2020, 10:32 AM

Addshore moved this task from Ready for Breakdown to Prioritized backlog (aka Ready to pick up) on the Wikibase - Federated Properties board.

• toan moved this task from Prioritized backlog (aka Ready to pick up) to Sprint 2/6 (Hike 2) on the Wikibase - Federated Properties board.Jul 2 2020, 8:38 AM

• toan edited projects, added Wikibase - Federated Properties (Sprint 2/6 (Hike 2)); removed Wikibase - Federated Properties.

• toan claimed this task.Jul 2 2020, 8:44 AM

• toan moved this task from To do to Doing on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.

Change 609126 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: GenericActionApiClient sends useragent

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /609126

gerritbot added a project: Patch-For-Review.Jul 2 2020, 10:43 AM

• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 2 2020, 11:29 AM

• toan moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 3 2020, 11:40 AM

• toan moved this task from Doing to Peer Review on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 3 2020, 12:22 PM

Addshore moved this task from Peer Review to Doing on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 6 2020, 12:58 PM

Change 609126 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: GenericActionApiClient sends useragent

https://gerrit.wikimedia.org/r/609126

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 6 2020, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Jul 6 2020, 7:11 PM

Rosalie_WMDE moved this task from Doing to Done on the Wikibase - Federated Properties (Sprint 2/6 (Hike 2)) board.Jul 6 2020, 7:34 PM

Change 610033 had a related patch set uploaded (by Tobias Andersson; owner: Tobias Andersson):
[mediawiki/extensions/Wikibase@master] FP: Add section about privacy

https://gerrit.wikimedia.org/r/610033

gerritbot added a project: Patch-For-Review.Jul 7 2020, 11:55 AM

@toan here is a revised version of your proposed text for the fed props documentation:

"Once you enable Federated Properties in your Wikibase installation, all requests to the federation source Wiki will include an anonymized unique identifier as the useragent. This will be used only to detect abnormal traffic to the source Wiki for the purposes of preventing abuse."

In T256226#6285311, @Samantha_Alipio_WMDE wrote:

@toan here is a revised version of your proposed text for the fed props documentation:

"Once you enable Federated Properties in your Wikibase installation, all requests to the federation source Wiki will include an anonymized unique identifier as the useragent. This will be used only to detect abnormal traffic to the source Wiki for the purposes of preventing abuse."

done!

Change 610033 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] FP: Add section about privacy

https://gerrit.wikimedia.org/r/610033

ReleaseTaggerBot edited projects, added MW-1.35-notes (1.35.0-wmf.41; 2020-07-14); removed MW-1.35-notes (1.35.0-wmf.40; 2020-07-07).Jul 8 2020, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 8 2020, 11:10 AM

Addshore closed this task as Resolved.Jul 15 2020, 8:17 AM