"Database selection is disallowed to enable reuse" is badly worded
Closed, ResolvedPublic
Actions

Description

"Database selection is disallowed to enable reuse." is used in DBConnRef as error messages in 4 places...

What does it even mean?

Caused by 6ab57b9c2424d9cc01b29908658b273a6ce75489

Details

Subject	Repo	Branch	Lines +/-
rdbms: improve DBConnRef domain selection exception message	mediawiki/core	REL1_35	+17 -5
rdbms: improve DBConnRef domain selection exception message	mediawiki/core	REL1_34	+17 -5
rdbms: improve DBConnRef domain selection exception message	mediawiki/core	master	+17 -5

Customize query in gerrit

Related Objects

Mentioned Here: rMW6ab57b9c2424: rdbms: restrict more unsafe IDatabase methods in DBConnRef

Event Timeline

Reedy created this task.Jun 24 2020, 5:12 PM

Restricted Application added a project: Platform Engineering. · View Herald TranscriptJun 24 2020, 5:12 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy added a project: MediaWiki-Documentation.Jun 24 2020, 5:16 PM

Reedy added a project: Performance-Team.Jun 24 2020, 5:22 PM

Reedy updated the task description. (Show Details)

Reedy added a subscriber: aaron.

Aklapper removed a project: MediaWiki-Documentation.Jun 24 2020, 5:36 PM

aaron claimed this task.Jun 24 2020, 8:14 PM

aaron triaged this task as Low priority.

BPirkle edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.Jun 24 2020, 8:47 PM

BPirkle moved this task from Inbox to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.

• Gilles moved this task from Inbox, needs triage to Doing (old) on the Performance-Team board.Jun 29 2020, 8:10 PM

Krinkle edited projects, added Developer Productivity; removed Voice & Tone.Jul 1 2020, 5:42 PM

lcawte subscribed.Jul 2 2020, 6:28 PM

Change 615318 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] rdbms: improve DBConnRef domain selection exception message

https://gerrit.wikimedia.org/r/615318

gerritbot added a project: Patch-For-Review.Jul 21 2020, 11:07 PM

Change 615318 merged by jenkins-bot:
[mediawiki/core@master] rdbms: improve DBConnRef domain selection exception message

https://gerrit.wikimedia.org/r/615318

Change 616928 had a related patch set uploaded (by Reedy; owner: Aaron Schulz):
[mediawiki/core@REL1_35] rdbms: improve DBConnRef domain selection exception message

https://gerrit.wikimedia.org/r/616928

Change 616929 had a related patch set uploaded (by Reedy; owner: Aaron Schulz):
[mediawiki/core@REL1_34] rdbms: improve DBConnRef domain selection exception message

https://gerrit.wikimedia.org/r/616929

Reedy closed this task as Resolved.Jul 28 2020, 11:44 PM

Change 616928 merged by jenkins-bot:
[mediawiki/core@REL1_35] rdbms: improve DBConnRef domain selection exception message