HookContainer: Call to a member function serialize() on null
Closed, ResolvedPublic1 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.35.0-wmf.37

message

Call to a member function serialize() on null

Impact

Unclear.

Notes

A couple of these just now in wmf.37. Not obviously exploding, but the feature doesn't see much use.

Initially tagging Wikidata-Campsite - please correct if mistaken.

Details

Request ID: 8e330672-6144-481b-b5e2-e90e78dd50e0
Request URL: https://cs.wikipedia.org/w/index.php?title=Demence&action=submit

Stack Trace

exception.trace

#0 /srv/mediawiki/php-1.35.0-wmf.37/includes/HookContainer/HookContainer.php(319): TwoColConflict\Hooks\TwoColConflictHooks::onEditPageBeforeConflictDiff(EditPage, OutputPage)
#1 /srv/mediawiki/php-1.35.0-wmf.37/includes/HookContainer/HookContainer.php(131): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#2 /srv/mediawiki/php-1.35.0-wmf.37/includes/HookContainer/HookRunner.php(1537): MediaWiki\HookContainer\HookContainer->run(string, array)
#3 /srv/mediawiki/php-1.35.0-wmf.37/includes/EditPage.php(3836): MediaWiki\HookContainer\HookRunner->onEditPageBeforeConflictDiff(EditPage, OutputPage)
#4 /srv/mediawiki/php-1.35.0-wmf.37/includes/EditPage.php(3064): EditPage->showConflict()
#5 /srv/mediawiki/php-1.35.0-wmf.37/includes/EditPage.php(617): EditPage->showEditForm()
#6 /srv/mediawiki/php-1.35.0-wmf.37/includes/actions/EditAction.php(59): EditPage->edit()
#7 /srv/mediawiki/php-1.35.0-wmf.37/includes/actions/SubmitAction.php(38): EditAction->show()
#8 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(527): SubmitAction->show()
#9 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(313): MediaWiki->performAction(Article, Title)
#10 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(986): MediaWiki->performRequest()
#11 /srv/mediawiki/php-1.35.0-wmf.37/includes/MediaWiki.php(543): MediaWiki->main()
#12 /srv/mediawiki/php-1.35.0-wmf.37/index.php(47): MediaWiki->run()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Fix "call on null" error in logging code	mediawiki/extensions/TwoColConflict	master	+15 -11

Customize query in gerrit

Event Timeline

brennen created this task.Jun 24 2020, 6:09 PM

Restricted Application added a project: Wikidata. · View Herald TranscriptJun 24 2020, 6:09 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Jun 24 2020, 6:10 PM

Krinkle moved this task from Untriaged to Jun 2020 on the Wikimedia-production-error board.Jun 24 2020, 6:58 PM

Revsion seems to exists, but getContent can return null

There are revision deletion in the history - https://cs.wikipedia.org/w/index.php?title=Demence&action=history
Maybe the revision deletion was done while the revision was open in the editor and than submitted.

			if ( $baseRevision && $latestRevision ) {
				// Attempt the automatic merge, to measure the number of actual conflicts.
				/** @var ThreeWayMerge $merge */
				$merge = MediaWikiServices::getInstance()->getService( 'TwoColConflictThreeWayMerge' );
				$result = $merge->merge3(
					$baseRevision->getContent( SlotRecord::MAIN )->serialize(),
					$latestRevision->getContent( SlotRecord::MAIN )->serialize(),
					$editPage->textbox2
				);

				if ( !$result->isCleanMerge() ) {
					$conflictChunks = $result->getOverlappingChunkCount();
					$conflictChars = $result->getOverlappingChunkSize();
				}
			}

WMDE-Fisch added subscribers: thiemowmde, awight.Jun 25 2020, 6:42 PM

This doesn't have anything to do with wikidata/wikibase.

Change 614691 had a related patch set uploaded (by Thiemo Kreuz (WMDE); owner: Thiemo Kreuz (WMDE)):
[mediawiki/extensions/TwoColConflict@master] Fix "call on null" error in logging code

https://gerrit.wikimedia.org/r/614691

gerritbot added a project: Patch-For-Review.Jul 20 2020, 8:42 AM

thiemowmde claimed this task.Jul 20 2020, 8:43 AM

thiemowmde moved this task from Backlog to Tickets in sprint on the Two-Column-Edit-Conflict-Merge board.

thiemowmde added a project: WMDE-QWERTY-Sprint-2020-07-08.

thiemowmde set the point value for this task to 1.

thiemowmde moved this task from Sprint Backlog to Review on the WMDE-QWERTY-Sprint-2020-07-08 board.

thiemowmde added a subscriber: Andrew-WMDE.

Change 614691 merged by jenkins-bot:
[mediawiki/extensions/TwoColConflict@master] Fix "call on null" error in logging code

https://gerrit.wikimedia.org/r/614691

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 20 2020, 10:00 AM

Maintenance_bot removed a project: Patch-For-Review.Jul 20 2020, 10:10 AM