Page MenuHomePhabricator

Fatal Error: Class MediaWiki\HookContainer\HookRunner contains 1 abstract method and must therefore be declared abstract
Closed, DuplicatePublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.35.0-wmf.38

message
PHP Fatal Error: Class MediaWiki\HookContainer\HookRunner contains 1 abstract method and must therefore be declared abstract or implement the remaining methods (MediaWiki\ChangeTags\Hook\ChangeTagsAllowedAddHook::onChangeTagsAllowedAdd)

Impact

Unknown, but this smells pretty broken.

Notes

A spike of 222 of these after deploy of wmf.38 to group1.

Details

Request ID
61503c47-dc8e-4b57-9dd2-2ed4081cd9c4
Request URL
https://commons.wikimedia.org/w/api.php
Stack Trace
exception.trace
#0 [internal function]: MWExceptionHandler::handleFatalError()
#1 {main}

Event Timeline

brennen created this task.Jun 24 2020, 7:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 24 2020, 7:22 PM
brennen triaged this task as Unbreak Now! priority.Jun 24 2020, 7:23 PM

This seems borked. HookRunner does have onChangeTagsAllowedAdd. Also, such a broken piece of code would have been spotted by several tests. Perhaps some internal PHP bug due to the many implements?

BPirkle added a subscriber: BPirkle.

Unclear how this would have worked on group0. We will look into it further to see what we can learn.

BPirkle added a subscriber: tstarling.

@tstarling , does this make any sense to you?

All of these were on a single server (mw1287). Some sort of opcache issue or something?

Ladsgroup added a comment.EditedJun 24 2020, 8:13 PM

All of these were on a single server (mw1287). Some sort of opcache issue or something?

Yes, very very likely T253673: Avoid php-opcache corruption in WMF production. Can you restart fpm and see if it goes away?

Mentioned in SAL (#wikimedia-operations) [2020-06-24T20:32:18Z] <cdanis> restarting php-fpm on mw1287 T256305

Mentioned in SAL (#wikimedia-operations) [2020-06-24T20:41:22Z] <brennen> train 1.35.0-wmf.38: attempting to roll forward to group1 after php-fpm restart on mw1287 (T256305, T254175)

brennen closed this task as Resolved.Jun 24 2020, 8:51 PM
brennen claimed this task.

Looks like that was it. Thanks all.