Page MenuHomePhabricator

References may disappear in DiscussionTools when switching from visual to wikitext (or saving)
Open, Needs TriagePublic

Assigned To
None
Authored By
matmarex
Jun 24 2020, 9:34 PM
Referenced Files
F31904333: image.png
Jun 24 2020, 9:34 PM
F31904335: image.png
Jun 24 2020, 9:34 PM
F31904339: image.png
Jun 24 2020, 9:34 PM
F31904337: image.png
Jun 24 2020, 9:34 PM

Description

References may disappear in DiscussionTools when switching from visual to wikitext (or saving).

I noticed this when testing the patches for T256292 (so this is only reproducible on Beta right now).

Steps to reproduce:

  1. Type in a comment with a reference in source mode, e.g. a <ref>b</ref> c
    image.png (522×2 px, 73 KB)
  2. Switch to visual, auto-generated reflist appears
    image.png (522×2 px, 75 KB)
  3. Delete the reflist
    image.png (522×2 px, 59 KB)
  4. Switch to wikitext (or save), the reference disappears
    image.png (522×2 px, 70 KB)

I think deleting the reflist is a reasonable thing to do; when posting a comment with references, you would usually want the reflist at the bottom of the page (or the section), and definitely not before your signature (which is where it will appear if it's inside the comment you type).

Event Timeline

JTannerWMF subscribed.

In Triage we determined we wanted to work on this

T256150 will disallow switching to VE with references, making this task invalid.

matmarex edited projects, added Editing-team; removed Editing-team (Kanban Board).

Maybe we'll come back to this after we have multi-line comments and re-enable switching.