| • jbolorinos-ctr | |
| Jun 25 2020, 2:07 AM |
| F31904540: image.png | |
| Jun 25 2020, 2:14 AM |
| F31904532: image.png | |
| Jun 25 2020, 2:08 AM |
Steps to Reproduce:
Desktop example:
Mobile example:
Actual Results:
Currently the comma is missing on older versions of Safari 9.0 and earlier (verified on the iPad Mini the foundation lent me).
Expected Results:
We would expect the comma to appear in older versions of Safari
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | • jbolorinos-ctr | T255813 Early QA: Japan Banners | |||
| Declined | BUG REPORT | • jbolorinos-ctr | T256347 [All Controls] Missing comma on donation amounts in older versions of Safari |
This is because we normally use the built-in Intl.NumberFormat method in frb.formatCurrency, but it isn't supported before Safari 10 (https://caniuse.com/#feat=mdn-javascript_builtins_intl_numberformat_format), so we just fall back to constructing the number manually.
We could potentially improve that to include thousands separators, but given the built-in method works for the vast majority of users and thousands separators are not essential, triaging as Lowest.