New logo overlaps with the top menu (personal menu) in portrait mode
Closed, DuplicatePublic
Actions

Description

This is how the new header looks on iPad with portrait mode:

This will be resolved by: T256893: Move the PersonalMenu to the header

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/skins/Vector	master	+75 -65	[modern] Move the PersonalMenu into the Header

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T29911 Overhaul and standardize apple-touch-icons
Open		None	T34101 High-density display issues (HiDPI) (tracking)
Duplicate		None	T54019 Vectorize all project logos
Resolved		Jdlrobson	T16501 A way to hide the sidebar providing a "fullscreen" view
Resolved		ovasileva	T247032 [EPIC] Build collapsible sidebar and deploy to all test wikis
Resolved	Goal	ovasileva	T242131 [GOAL] Deploy new header to at least one test wiki
Resolved		Jdlrobson	T240856 [EPIC] New header for desktop improvements project
Open	Spike	None	T244486 Create new logos for all projects for DI header
Resolved		Jdlrobson	T251903 Translate's NaviToggle should be hidden in modern Vector
Resolved		ovasileva	T246419 Build collapsible sidebar and sidebar button
Resolved		ovasileva	T246170 Build new logo for Desktop Improvements Header
Duplicate		• Demian	T256373 New logo overlaps with the top menu (personal menu) in portrait mode

Event Timeline

sgrabarczuk created this task.Jun 25 2020, 2:01 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2020, 2:01 PM

I suggest the layout be made responsive to screen width, so that the logo doesn't exceed the sidebar width when the screen is not wider than a certain threshold, maybe 800px.

@JohanahoJ Thank you for the report, it's being worked on, expected to be merged in the coming days.

Change 585629 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] [modern] Move the PersonalMenu into the Header

https://gerrit.wikimedia.org/r/585629

gerritbot added a project: Patch-For-Review.Jun 25 2020, 2:21 PM

• Demian added a project: Readers-Web-Backlog (Kanbanana-2019-20-Q4).Jun 25 2020, 5:28 PM

• Demian moved this task from Needs Analysis to Needs Code Review on the Readers-Web-Backlog (Kanbanana-2019-20-Q4) board.

Jdlrobson moved this task from Needs Code Review to Needs Analysis on the Readers-Web-Backlog (Kanbanana-2019-20-Q4) board.Jun 25 2020, 5:44 PM

This is a known problem just a low priority as I understand it given we plan to redesign that menu and we default to Minerva/mobile site on iPad.

• Demian claimed this task.Jul 1 2020, 5:00 PM

• Demian updated the task description. (Show Details)

Volker_E mentioned this in T256893: Move the PersonalMenu to the header.Jul 1 2020, 5:06 PM

Cleaning up workboard... task continued to be tracked on T256893: Move the PersonalMenu to the header

I would like us to continue analyzing this task and perhaps expand it to include all cases for smaller screens. @Demian, in the future, please don't remove items from our sprint board.

In T256373#6280924, @ovasileva wrote:

I would like us to continue analyzing this task and perhaps expand it to include all cases for smaller screens. @Demian, in the future, please don't remove items from our sprint board.

@ovasileva The work is tracked in T256893, this report is kind of a duplicate, but given the fundamentally different perspective, IMO it wouldn't be appropriate to close as such.
However, to avoid confusion, you might want to add that task to the workboard instead, which I intended to do, but unfortunately forgot about.
To clarify, once that task is merged it won't be possible for the logo (referred to as "new header" in this ticket) to overlap the personal menu (referred to as "top menu"). As such there will be nothing to analyze. If you meant analyzing any other possible overlap, that's not the scope of this report.

By removing this project from your workboard I wished to communicate this fact. I reckon I didn't explain this clearly, for which I'm sorry. I expected that it's obvious and/or you're aware of this from communication with your colleagues.

• Demian renamed this task from New header overlaps with the top menu in portrait mode to New logo overlaps with the top menu (personal menu) in portrait mode.Jul 6 2020, 12:23 PM

MBinder_WMF edited projects, added Readers-Web-Backlog (Kanbanana-FY-2020-21); removed Readers-Web-Backlog (Kanbanana-2019-20-Q4).Jul 9 2020, 5:22 PM

I've folded this into T257279 - @ovasileva @sgrabarczuk would it be okay to merge this task into that one or do you want to keep this open and stall it on that one?

In T256373#6297944, @Jdlrobson wrote:

I've folded this into T257279 - @ovasileva @sgrabarczuk would it be okay to merge this task into that one or do you want to keep this open and stall it on that one?

Would that mean only QA for this one? I'm okay with either so long as we can pull the description from here as well

ovasileva triaged this task as Medium priority.Jul 13 2020, 10:13 AM

@ovasileva I've added QA steps to T56373 to make sure this is accounted for. It will be fixed as part of that change.

In T256373#6306379, @Jdlrobson wrote:

@ovasileva I've added QA steps to T56373 to make sure this is accounted for. It will be fixed as part of that change.

Perfect, thank you. Will QA in T249363: Move the existing search to the header in preparation for Vue.js search development

Change 585629 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] [modern] Move the PersonalMenu into the Header

Reason:
Done in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/ /610187

https://gerrit.wikimedia.org/r/585629