This is how the new header looks on iPad with portrait mode:
Related
This will be resolved by: T256893: Move the PersonalMenu to the header
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/skins/Vector | master | +75 -65 | [modern] Move the PersonalMenu into the Header |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Jdlrobson | T16501 A way to hide the sidebar providing a "fullscreen" view | |||
| Resolved | ovasileva | T247032 [EPIC] Build collapsible sidebar and deploy to all test wikis | |||
| Resolved | Goal | ovasileva | T242131 [GOAL] Deploy new header to at least one test wiki | ||
| Resolved | Jdlrobson | T240856 [EPIC] New header for desktop improvements project | |||
| Duplicate | None | T54019 Vectorize all project logos | |||
| Open | Spike | None | T244486 [EPIC] Logo overhaul, create new logos for all projects for DI header and make sure everyone knows how to use them | ||
| Resolved | Jdlrobson | T251903 Translate's NaviToggle should be hidden in modern Vector | |||
| Resolved | ovasileva | T246419 Build collapsible sidebar and sidebar button | |||
| Resolved | ovasileva | T246170 Build new logo for Desktop Improvements Header | |||
| Duplicate | • Demian | T256373 New logo overlaps with the top menu (personal menu) in portrait mode |
Event Timeline
Comment Actions
I suggest the layout be made responsive to screen width, so that the logo doesn't exceed the sidebar width when the screen is not wider than a certain threshold, maybe 800px.
Comment Actions
@JohanahoJ Thank you for the report, it's being worked on, expected to be merged in the coming days.
Comment Actions
Change 585629 had a related patch set uploaded (by Aron Manning; owner: Aron Manning):
[mediawiki/skins/Vector@master] [modern] Move the PersonalMenu into the Header
Comment Actions
This is a known problem just a low priority as I understand it given we plan to redesign that menu and we default to Minerva/mobile site on iPad.
Comment Actions
Cleaning up workboard... task continued to be tracked on T256893: Move the PersonalMenu to the header
Comment Actions
I would like us to continue analyzing this task and perhaps expand it to include all cases for smaller screens. @Demian, in the future, please don't remove items from our sprint board.
Comment Actions
@ovasileva The work is tracked in T256893, this report is kind of a duplicate, but given the fundamentally different perspective, IMO it wouldn't be appropriate to close as such.
However, to avoid confusion, you might want to add that task to the workboard instead, which I intended to do, but unfortunately forgot about.
To clarify, once that task is merged it won't be possible for the logo (referred to as "new header" in this ticket) to overlap the personal menu (referred to as "top menu"). As such there will be nothing to analyze. If you meant analyzing any other possible overlap, that's not the scope of this report.
By removing this project from your workboard I wished to communicate this fact. I reckon I didn't explain this clearly, for which I'm sorry. I expected that it's obvious and/or you're aware of this from communication with your colleagues.
Comment Actions
I've folded this into T257279 - @ovasileva @sgrabarczuk would it be okay to merge this task into that one or do you want to keep this open and stall it on that one?
Comment Actions
Would that mean only QA for this one? I'm okay with either so long as we can pull the description from here as well
Comment Actions
@ovasileva I've added QA steps to T56373 to make sure this is accounted for. It will be fixed as part of that change.
Comment Actions
Perfect, thank you. Will QA in T249363: Move the existing search to the header in preparation for Vue.js search development
Comment Actions
Change 585629 abandoned by Jdlrobson:
[mediawiki/skins/Vector@master] [modern] Move the PersonalMenu into the Header
Reason:
Done in https://gerrit.wikimedia.org/r/c/mediawiki/skins/Vector/ /610187