Page MenuHomePhabricator
Create Task
Maniphest T256382

Publish pending indicator layout is broken on the CAT tool
Closed, ResolvedPublic
Actions

Assigned To
Etonkovidova
Authored By
mwilliams
Jun 25 2020, 3:45 PM
Tags
Referenced Files
F31934441: Screen Shot 2020-07-13 at 3.43.44 PM.png
Jul 13 2020, 11:39 PM
F31934449: Screen Shot 2020-07-13 at 3.26.18 PM.png
Jul 13 2020, 11:39 PM
F31934443: Screen Shot 2020-07-13 at 3.45.12 PM.png
Jul 13 2020, 11:39 PM
F31934445: Screen Shot 2020-07-13 at 4.19.20 PM.png
Jul 13 2020, 11:39 PM
F31905484: Screen Shot 2020-06-25 at 8.16.24 AM.png
Jun 25 2020, 3:45 PM
Subscribers
Aklapper
AnneT
CBogen
mwilliams

Description

We have this: Currently the loading indicator thats shows up when you press publish is above the image on the CAT tool which may have happened when we switched to VUE

We want this: The loading indicator should be vertically and horizontally centered within the image card container

Screenshot of the current layout:

Screen Shot 2020-06-25 at 8.16.24 AM.png (2×3 px, 2 MB)

During development, please test the following:

  • Test this feature while logged in AND logged out - not applicable
  • Test this feature on at least one mobile browser
  • Test that this feature works on the file page AND the Add Data step on UploadWizard (if applicable, some features only exist on one or the other) - not applicable

Details

SubjectRepoBranchLines +/-
Fix publish pending indicator layoutmediawiki/extensions/MachineVisionmaster+11 -11
Customize query in gerrit

Event Timeline

mwilliams created this task.Jun 25 2020, 3:45 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 25 2020, 3:45 PM
mwilliams renamed this task from Loading indicator is in wrong location on CAT to Loading indicator is showing up in wrong location on the CAT tool.Jun 25 2020, 3:49 PM
AnneT renamed this task from Loading indicator is showing up in wrong location on the CAT tool to Publish pending indicator layout is broken on the CAT tool.Jun 25 2020, 4:08 PM
CBogen edited projects, added Structured-Data-Backlog (Current Work); removed Structured-Data-Backlog.Jun 25 2020, 4:32 PM
AnneT moved this task from Incoming to Doing on the Structured-Data-Backlog (Current Work) board.Jun 25 2020, 4:37 PM
gerritbot added a comment.Jun 25 2020, 6:31 PM

Change 607860 had a related patch set uploaded (by Anne Tomasevich; owner: Anne Tomasevich):
[mediawiki/extensions/MachineVision@master] Fix publish pending indicator layout

https://gerrit.wikimedia.org/r/607860

gerritbot added a project: Patch-For-Review.Jun 25 2020, 6:31 PM
AnneT moved this task from Doing to Code Review on the Structured-Data-Backlog (Current Work) board.Jun 25 2020, 6:33 PM
gerritbot added a comment.Jul 7 2020, 8:46 PM

Change 607860 merged by jenkins-bot:
[mediawiki/extensions/MachineVision@master] Fix publish pending indicator layout

https://gerrit.wikimedia.org/r/607860

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 7 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 7 2020, 9:10 PM
AnneT moved this task from Code Review to Needs QA on the Structured-Data-Backlog (Current Work) board.Jul 7 2020, 9:13 PM
• Ramsey-WMF reassigned this task from AnneT to Etonkovidova.Jul 9 2020, 8:33 PM
Etonkovidova updated the task description. (Show Details)Jul 13 2020, 11:29 PM
Etonkovidova added a comment.Jul 13 2020, 11:39 PM

The loading indicator should be vertically and horizontally centered on top of the image

Tested in betalabs - seems that the dots are aligned centrally in "wbmad-image-with-suggestions__container" element, not as in the task description

@AnneT - please review the following images for whether the position of the loading indicator should be adjusted or not.

Screen Shot 2020-07-13 at 3.43.44 PM.png (708×907 px, 397 KB)
Screen Shot 2020-07-13 at 3.45.12 PM.png (713×847 px, 259 KB)
Screen Shot 2020-07-13 at 4.19.20 PM.png (741×718 px, 404 KB)

Besides, when an image is small (as it's the case with betalabs Special:SuggestedTags#popular, it might be problematic to display the indicator at the top of such images. I'm not sure if such examples in betalabs reflect real production display of small images and to what extent the container for images display would adjust to the images sizes.

Screen Shot 2020-07-13 at 3.26.18 PM.png (643×876 px, 77 KB)

AnneT added a comment.Jul 14 2020, 1:08 AM

Hey @Etonkovidova, I think the loading indicator should be centered vertically within the entire image card, not the image; my language in the task description was inaccurate. Thanks for checking!

AnneT updated the task description. (Show Details)Jul 14 2020, 1:09 AM
Etonkovidova closed this task as Resolved.Jul 16 2020, 12:17 AM

Thanks for clarification, @AnneT - the task states "horizontally centered within the image card container" is accurate, just double-checking.

Checked in wmf.41 - all is in place.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL