Page MenuHomePhabricator

ChangeTags are broken in postgres (at least in unit tests)
Closed, ResolvedPublic

Description

ChageTagsTest is currently skipped because it fails in postgres, see T195807. It seems that this isn't just a fluke, but tags are actually broken in postgres - we had to skip tag related tests in our work for T252202 (see https://gerrit.wikimedia.org/r/c/mediawiki/core/+/596011/56). Contributions were coming back with several (all?) tags set, instead of just the tag we set on it:

10) MediaWiki\Tests\Revision\ContributionsLookupTest::testPermissionChecksAreApplied
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 'test-ContributionsLookup-2'
+    0 => 'mw-replace'
+    1 => 'mw-new-redirect'
+    2 => 'test-ContributionsLookup-1'
+    3 => 'test-ContributionsLookup-2'
 )

Event Timeline

eprodromou moved this task from Inbox to Icebox on the Platform Engineering board.
eprodromou added a subscriber: eprodromou.

This seems important for PostgreSQL. Moved to Icebox.

Change 756110 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Fix signature of DatabasePostgres::buildGroupConcatField

https://gerrit.wikimedia.org/r/756110

Change 756110 merged by jenkins-bot:

[mediawiki/core@master] Fix signature of DatabasePostgres::buildGroupConcatField

https://gerrit.wikimedia.org/r/756110

Umherirrender claimed this task.

Change 756077 had a related patch set uploaded (by Ammarpad; author: Umherirrender):

[mediawiki/core@REL1_37] Fix signature of DatabasePostgres::buildGroupConcatField

https://gerrit.wikimedia.org/r/756077

Change 756077 merged by jenkins-bot:

[mediawiki/core@REL1_37] Fix signature of DatabasePostgres::buildGroupConcatField

https://gerrit.wikimedia.org/r/756077