Page MenuHomePhabricator
Create Task
Maniphest T256500

TableCellNode throws exception if still active when torn down
Closed, ResolvedPublic
Actions

Description

157 errors per 12hr period on mediawiki.org (this is the most common client side error outside gadgets at the moment)

https://logstash.wikimedia.org/goto/e98d2f5d14b561bae47d9be4a5b9b0af

at VeCeTableCellNode.ve.ce.Node.getOffset  https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.base%2Ccore%2Csanitize%7Cext.visualEditor.core.utils&skin=vector&version=3uyj5:397:80
at VeCeTableCellNode.ve.Node.getRange  https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.base%2Ccore%2Csanitize%7Cext.visualEditor.core.utils&skin=vector&version=3uyj5:25:322
at VeCeSurface.ve.ce.Surface.handleObservedChanges  https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.base%2Ccore%2Csanitize%7Cext.visualEditor.core.utils&skin=vector&version=3uyj5:499:492
at VeCeSurfaceObserver.ve.ce.SurfaceObserver.pollOnceInternal  https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.base%2Ccore%2Csanitize%7Cext.visualEditor.core.utils&skin=vector&version=3uyj5:524:488
at VeCeSurfaceObserver.ve.ce.SurfaceObserver.pollOnceSelection  https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.base%2Ccore%2Csanitize%7Cext.visualEditor.core.utils&skin=vector&version=3uyj5:524:61
at VeCeSurface.ve.ce.Surface.onDocumentSelectionChange  https://www.mediawiki.org/w/load.php?lang=en&modules=ext.visualEditor.base%2Ccore%2Csanitize%7Cext.visualEditor.core.utils&skin=vector&version=3uyj5:458:434
at later  https://www.mediawiki.org/w/load.php?lang=en&modules=ext.flow%2Cthanks%7Cext.flow.components%2Cdm%2Ctemplating%2Cui%7Cext.flow.jquery.conditionalScroll%2CfindWithParent%7Cext.flow.visualEditor.icons%7Cext.thanks.flowthank%7Cjquery%2Coojs-ui%2Coojs-ui-core%2Coojs-ui-toolbars%2Coojs-ui-widgets%2Csite%7Cjquery.throttle-debounce%7Cmediawiki.template%7Cmediawiki.template.handlebars%7Coojs-ui-toolbars.icons%7Coojs-ui.styles.icons-editing-advanced%2Cicons-editing-list&skin=vector&version=1d81o:407:240

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/VisualEditormaster+3 -1Update VE core submodule to master (806716154)
VisualEditor/VisualEditormaster+20 -0Clear surface.activeNode when table cell is torn down
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Jun 26 2020, 6:30 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2020, 6:30 PM
Krinkle moved this task from Untriaged to Jun 2020 on the Wikimedia-production-error board.Jun 30 2020, 5:59 PM
JTannerWMF added a project: Editing-team (Q3 2019-2020 Kanban Board).Jun 30 2020, 7:20 PM
JTannerWMF added a subscriber: JTannerWMF.

Editing will investigate

JTannerWMF moved this task from Needs Discussion / Investigation to Ready for Development on the Editing-team (Q3 2019-2020 Kanban Board) board.Jun 30 2020, 7:20 PM
Esanders added a subscriber: Esanders.Jul 2 2020, 1:31 PM

I can reproduce a version of this error (probably not the same root cause):

  1. Insert a new table
  2. Double click on a cell to edit it
  3. Press undo to delete the table
  4. Click somewhere on the page to reposition the cursor
Esanders renamed this task from Uncaught TypeError: Cannot read property 'getOffset' of null to TableCellNode throws exception if still active when torn down.Jul 2 2020, 1:38 PM
gerritbot added a comment.Jul 2 2020, 1:43 PM

Change 609159 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Clear surface.activeNode when table cell is torn down

https://gerrit.wikimedia.org/r/c/VisualEditor/VisualEditor/ /609159

gerritbot added a project: Patch-For-Review.Jul 2 2020, 1:43 PM
Esanders claimed this task.Jul 2 2020, 1:47 PM
Esanders moved this task from Ready for Development to Code Review on the Editing-team (Q3 2019-2020 Kanban Board) board.
matmarex moved this task from To Triage to Triaged on the VisualEditor board.Jul 3 2020, 2:27 AM
gerritbot added a comment.Jul 8 2020, 8:26 PM

Change 609159 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Clear surface.activeNode when table cell is torn down

https://gerrit.wikimedia.org/r/609159

gerritbot added a comment.Jul 8 2020, 9:03 PM

Change 610372 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (806716154)

https://gerrit.wikimedia.org/r/610372

gerritbot added a comment.Jul 8 2020, 9:23 PM

Change 610372 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (806716154)

https://gerrit.wikimedia.org/r/610372

matmarex moved this task from Code Review to QA on the Editing-team (Q3 2019-2020 Kanban Board) board.Jul 8 2020, 9:31 PM
matmarex edited projects, added Editing QA; removed Patch-For-Review.
MBinder_WMF edited projects, added Editing-team (Kanban Board); removed Editing-team (Q3 2019-2020 Kanban Board).Jul 9 2020, 4:47 PM
JTannerWMF moved this task from Incoming to QA on the Editing-team (Kanban Board) board.Jul 9 2020, 4:48 PM
Krinkle closed this task as Resolved.Sep 3 2020, 8:16 PM
Krinkle added a subscriber: Krinkle.

No longer seen for 30 days in Logstash.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptSep 3 2020, 8:16 PM
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL