|Open||None||T55733 Use the same icons to represent the same things (tracking)|
|Resolved||ovasileva||T256504 Page previews cog should use OOUI settings icon|
I might be wrong about the following, but I wonder if this change might increase the page load? Note this code is loaded for every single page view (at least in the article namespace). The patch replaces a tiny .svg file with a larger set of OOUI icons. This is not necessarily bad. The total page load will be smaller in situations where this icon set is loaded anyway, but larger if not. Do we know which situation is more common? @Krinkle, does the performance team want to have a look here?
I manually tested the patch. As far as I can see it looks fine. Below is a comparison:
- Before the patch.
- After the patch, as of patch set 3.
- Same, but when I remove this line here.
Note the gray rectangle is when you hover the icon with the mouse. I intentionally included this in the screenshots.
Personally, I find both #2 and #3 acceptable, with a tendency towards #3, because it is closer to the original design (and respects the mw-ui-icon-small style). @ECohen_WMDE, maybe you want to have a look?
I might be wrong about the following, but I wonder if this change might increase the page load?
The newly created icon pack should only contain one icon so should be the same size. There's a small bump in the startup module but that will be reclaimed when the other icons have been migrated there.
@alexhollender Agree, not much seems changed but the fact that it's centered seems like a nice improvement. Also seems like the icon is a bit larger, but that doesn't look like a problem to me. I think it'll be fine to eventually use the same, updated version on RefPreviews when we add the cog there.