Page MenuHomePhabricator

Gitiles on Gerrit 3.2 test instance loads fonts from third-party domain
Closed, ResolvedPublicBUG REPORT

Description

This was originally reported by @Paladox. Thanks!

This is not specific to Gerrit 3.2. Also gitiles of our currently live Gerrit v2.15.14 on gerrit.wikimedia.org is affected by this.

Upstream fix is at https://gerrit-review.googlesource.com/c/gerrit/+/273371

Event Timeline

Not sure they'll accept the upstream fix, since Gerrit does not provide all fonts in all weights that gitiles wants.
But Gerrit offers suitable alternatives (E.g.: gitiles wants 'Open Code Pro' as monospace font. Gerrit does not have 'Open Code Pro', but offers 'Roboto Mono').

The fix is currently deployed on https://gerrit-test.wikimedia.org

QChris changed the subtype of this task from "Task" to "Bug Report".Jun 26 2020, 8:16 PM

Since there was a question on T255977 regarding this gitiles fix, let's have a gitiles sample URL: https://gerrit-test.wikimedia.org/g/mediawiki/extensions/Translate/+/e59e33168f13d31867da701fec2640a099d37cae

This URL loads only resources from gerrit-test.wikimedia.org.
It also loads the fonts from gerrit-test.wikimedia.org.

gitiles base.css for review is at https://gerrit-test.wikimedia.org/r/plugins/gitiles/+static/base.css
It no longer holds font @imports from 3rd party domains.

Since there was a question on T255977 regarding this gitiles fix, let's have a gitiles sample URL: https://gerrit-test.wikimedia.org/g/mediawiki/extensions/Translate/+/e59e33168f13d31867da701fec2640a099d37cae

This URL loads only resources from gerrit-test.wikimedia.org.
It also loads the fonts from gerrit-test.wikimedia.org.

gitiles base.css for review is at https://gerrit-test.wikimedia.org/r/plugins/gitiles/+static/base.css
It no longer holds font @imports from 3rd party domains.

Perfect! Thank you :)