Maniphest T256510

Remove BaseTemplateAfterPortlet hook
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdlrobson
	Jun 26 2020, 9:51 PM

Tags

Referenced Files

None

Subscribers

Description

This hook was hard deprecated in 1.35 and we should look to remove it in 1.36
https://codesearch.wmflabs.org/search/?q=BaseTemplateAfterPortlet &i=nope&files=&repos=

There is only one active known consumer: GreyStuff

Details

	Subject	Repo	Branch	Lines +/-
	Update GreyStuff for 1.35	mediawiki/skins/GreyStuff	master	+44 -37

Customize query in gerrit

Related Objects

Mentioned In: T253809: [EPIC] Deprecate the BaseTemplate hooks

Event Timeline

Jdlrobson created this task.Jun 26 2020, 9:51 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 26 2020, 9:51 PM

Jdlrobson moved this task from Backlog to Milestone: More flexibility in article heading area (subpages, descriptions) on the MediaWiki-Core-Skin-Architecture board.Jun 26 2020, 9:56 PM

Jdlrobson mentioned this in T253809: [EPIC] Deprecate the BaseTemplate hooks.

DannyS712 moved this task from Blocker to To deprecate or remove on the MW-1.36-release board.Jun 26 2020, 10:50 PM

Change 608116 had a related patch set uploaded (by Mainframe98; owner: Mainframe98):
[mediawiki/skins/GreyStuff@master] Update GreyStuff for 1.35

https://gerrit.wikimedia.org/r/608116

gerritbot added a project: Patch-For-Review.Jun 27 2020, 8:00 AM

Jdlrobson moved this task from Milestone: More flexibility in article heading area (subpages, descriptions) to Backlog on the MediaWiki-Core-Skin-Architecture board.Jun 29 2020, 11:20 PM

Jdlrobson moved this task from Backlog to Phase 2 - Deprecate and remove Skin methods for readability on the MediaWiki-Core-Skin-Architecture board.

Change 608116 merged by jenkins-bot:
[mediawiki/skins/GreyStuff@master] Update GreyStuff for 1.35

https://gerrit.wikimedia.org/r/608116

Maintenance_bot removed a project: Patch-For-Review.Jul 15 2020, 4:10 PM

Fixed by above patch