Page MenuHomePhabricator

Remove SkinTemplateToolboxEnd hook
Open, Needs TriagePublic

Description

This hook was hard deprecated in 1.35 (T253783) and we should look to remove it in 1.36
https://codesearch.wmflabs.org/search/?q=SkinTemplateToolboxEnd&i=nope&files=&repos=

Certain skins such as Vector dropped support for the hook in T252917 so it's possible functionality will not work in 1.35 (although will not throw errors)

Also impacted:
RelatedLinks, advancedbacklinks, chameleon skin, DarkVector, SemanticWebBrowser, SemanticMediaWiki, erudite, p2wiki, WPtouch, foreground

Event Timeline

Gonna be honest, I don't even remotely understand the skin stuff that supports this. So I dunno how to remove it. >.>

Is this the deprecatedHookHack stuff in getPortlet?

Change 649769 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/WoOgLeShades@master] Use skinfeatures and updated skin functions

https://gerrit.wikimedia.org/r/649769

Change 649769 merged by jenkins-bot:
[mediawiki/skins/WoOgLeShades@master] Use skinfeatures and updated skin functions

https://gerrit.wikimedia.org/r/649769

Is this the deprecatedHookHack stuff in getPortlet?

Yep.

Gonna be honest, I don't even remotely understand the skin stuff that supports this. So I dunno how to remove it. >.>

That's good. Trying to move away from having to understand things that are not obvious. Skins don't need to concern themselves with hooks, they just need to use the methods in core.

Skins don't need to concern themselves with hooks, they just need to use the methods in core.

Well, I think the hack itself at least never left core, so that's a slight mercy. But even there I was just wrapping it up in some horrors and a general function so I never had to deal with it directly...

Change 650274 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/HasSomeColours@master] Use updated everything

https://gerrit.wikimedia.org/r/650274

Change 650274 merged by jenkins-bot:
[mediawiki/skins/HasSomeColours@master] Use updated everything

https://gerrit.wikimedia.org/r/650274

Change 644546 had a related patch set uploaded (by Zoranzoki21; owner: Zoranzoki21):
[mediawiki/extensions/Duplicator@master] Make extension compatible with the MediaWiki 1.35 and newer

https://gerrit.wikimedia.org/r/644546

Change 644546 abandoned by Zoranzoki21:
[mediawiki/extensions/Duplicator@master] Make extension compatible with the MediaWiki 1.35 and newer

Reason:
Let's work on one by one option.

https://gerrit.wikimedia.org/r/644546

Change 657881 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/LanguageSelector@master] SkinTemplateToolboxEnd is deprecated. Use SkinAfterPortlet

https://gerrit.wikimedia.org/r/657881

Change 673104 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Anisa@master] Use updated/core wodgits and bump required mw version to 1.35

https://gerrit.wikimedia.org/r/673104

Change 673104 merged by jenkins-bot:
[mediawiki/skins/Anisa@master] Use updated/core wodgits and bump required mw version to 1.35

https://gerrit.wikimedia.org/r/673104