Page MenuHomePhabricator
Create Task
Maniphest T256526

Items from watchlist no longer bolded at Special:RecentChangesLinked [[SMALL]] --> high priority
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To
Samwilson
Authored By
RWD
Jun 27 2020, 9:04 AM
Tags
Referenced Files
F32188012: Screen Shot 2020-08-18 at 6.48.46 PM.png
Aug 18 2020, 10:50 PM
F32051653: RecentChangesLinked.png
Aug 11 2020, 2:22 PM
Subscribers
Agusbou2015
Aklapper
DannyS712
dom_walden
ifried
RWD
Samwilson

Description

As a watchlist user, I want watched items to be properly indicated in Special:RecentChangesLinked, so I can see which items I am watching in the list.

Background: Checked on several wikis and wikidata. Seems that before Thursday it worked okay.

Acceptance Criteria:

  • Restore previous behavior for watched pages in Special:RecentChangesLinked

Details

SubjectRepoBranchLines +/-
Fix bold of watched items on Special:RecentChangesLinkedmediawiki/coreREL1_35+1 -1
Fix bold of watched items on Special:RecentChangesLinkedmediawiki/coremaster+1 -1
Customize query in gerrit

Related Objects

Event Timeline

RWD created this task.Jun 27 2020, 9:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2020, 9:04 AM
DannyS712 added projects: Regression, MediaWiki-Recent-changes, MediaWiki-Watchlist.Jun 27 2020, 9:34 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 27 2020, 9:34 AM
DannyS712 mentioned this in T254175: 1.35.0-wmf.38 deployment blockers.Jun 27 2020, 9:35 AM
DannyS712 triaged this task as High priority.Jun 27 2020, 9:39 AM
DannyS712 added subscribers: dom_walden, Samwilson, DannyS712.

Only recent change to Special:RecentChangesLinked appears to have been T252136: Watchlist Expiry: Update Special:RecentChanges to support watchlist expiry [medium] with 7eb5b726c92c479b82992e971b5e327d3a88a439

DannyS712 changed the subtype of this task from "Task" to "Bug Report".Jun 27 2020, 9:39 AM
Agusbou2015 subscribed.Jun 27 2020, 7:14 PM
dom_walden added projects: Expiring-Watchlist-Items, Community-Tech.Jul 28 2020, 1:59 PM

I think what is going on is...

When formatting the rows in recent changes, the code checks for non-null wl_user.

The SpecialRecentChangesLinked query does not include the wl_user column, so it acts as if these rows are not watched when outputting them.

ifried moved this task from New & TBD Tickets to Needs Discussion on the Community-Tech board.Jul 30 2020, 3:42 PM
ifried updated the task description. (Show Details)Jul 30 2020, 4:05 PM
ifried updated the task description. (Show Details)Jul 30 2020, 4:35 PM
ifried renamed this task from Items from watchlist no longer highlighted at Special:RecentChangesLinked to Items from watchlist no longer bolded at Special:RecentChangesLinked.Jul 30 2020, 5:09 PM
ARamirez_WMF renamed this task from Items from watchlist no longer bolded at Special:RecentChangesLinked to Items from watchlist no longer bolded at Special:RecentChangesLinked [[SMALL]].Jul 30 2020, 5:10 PM
ARamirez_WMF moved this task from Needs Discussion to Up Next (May 6-17) on the Community-Tech board.
ifried moved this task from Up Next (May 6-17) to Kanban-2020-21-Q1 on the Community-Tech board.Jul 30 2020, 5:12 PM
ifried edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban-2020-21-Q1). · View Herald TranscriptJul 30 2020, 5:12 PM
ifried moved this task from New & TBD Tickets to Kanban-2020-21-Q1 on the Community-Tech board.Jul 30 2020, 5:25 PM
ifried edited projects, added Community-Tech (Kanban-2020-21-Q1); removed Community-Tech.
ifried renamed this task from Items from watchlist no longer bolded at Special:RecentChangesLinked [[SMALL]] to Items from watchlist no longer bolded at Special:RecentChangesLinked [[SMALL]] --> high priority.Jul 30 2020, 9:02 PM
Samwilson claimed this task.Jul 30 2020, 9:57 PM
Samwilson moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (Kanban-2020-21-Q1) board.
gerritbot added a comment.Jul 30 2020, 10:10 PM

Change 617550 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Fix bold of watched items on Special:RecentChangesLinked

https://gerrit.wikimedia.org/r/617550

gerritbot added a project: Patch-For-Review.Jul 30 2020, 10:10 PM
Samwilson added a subscriber: ifried.Jul 30 2020, 10:37 PM

@ifried The other consequence of this change (once T258310 is resolved) is that watched items on RecentChangesLinked will also have the clock icon.

Samwilson moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (Kanban-2020-21-Q1) board.Jul 30 2020, 10:37 PM
gerritbot added a comment.Jul 31 2020, 8:27 PM

Change 617550 merged by jenkins-bot:
[mediawiki/core@master] Fix bold of watched items on Special:RecentChangesLinked

https://gerrit.wikimedia.org/r/617550

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.3; 2020-08-04).Jul 31 2020, 9:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 31 2020, 9:10 PM
ifried added a comment.Jul 31 2020, 9:29 PM

@Samwilson Ah cool, so users will also see the clock icon for temporarily watched items on RecentChangesLinked, as well, once T258310 is resolved? And will the hover functionality work, as well? If so, that's great news. Thanks!

Samwilson added a comment.Jul 31 2020, 11:25 PM

Yep and yep. :-)

gerritbot added a comment.Aug 1 2020, 9:44 AM

Change 617809 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@REL1_35] Fix bold of watched items on Special:RecentChangesLinked

https://gerrit.wikimedia.org/r/617809

gerritbot added a project: Patch-For-Review.Aug 1 2020, 9:44 AM
Samwilson moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (Kanban-2020-21-Q1) board.Aug 1 2020, 10:06 AM

This is merged and backported, and ready for QA.

gerritbot added a comment.Aug 1 2020, 5:18 PM

Change 617809 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix bold of watched items on Special:RecentChangesLinked

https://gerrit.wikimedia.org/r/617809

ReleaseTaggerBot added a project: MW-1.35-notes.Aug 1 2020, 6:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 1 2020, 6:10 PM
dom_walden moved this task from QA 🐛 to Product sign-off 🤘🏻 on the Community-Tech (Kanban-2020-21-Q1) board.Aug 11 2020, 2:22 PM

Bold highlighting and the clock now works on Special:RecentChangesLinked.

Tested for permanently and temporarily watched pages. Expired watched pages are not highlighted.

Also tested with watchlist expiry disabled (on my local environment). Permanently watched pages are highlighted.

RecentChangesLinked.png (585×1 px, 103 KB)

Test environment: https://test.wikipedia.org MediaWiki 1.36.0-wmf.3 (rMWe73e964e0655) 16:38, 7 August 2020

dom_walden mentioned this in T258310: Watchlist Expiry: display clock & remaining watch period in recentchanges [MEDIUM].Aug 12 2020, 9:51 AM
ifried closed this task as Resolved.Aug 18 2020, 10:50 PM
ifried moved this task from Product sign-off 🤘🏻 to Done 🏁 on the Community-Tech (Kanban-2020-21-Q1) board.

I have tested this on testwiki, and it looks good to me. I can see which items that I am watching in the list, including the clock icon if they are being temporarily watched. See screenshot example below. I'm marking this work as Done.

Screen Shot 2020-08-18 at 6.48.46 PM.png (488×1 px, 101 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL