Page MenuHomePhabricator

Items from watchlist no longer bolded at Special:RecentChangesLinked [[SMALL]] --> high priority
Open, HighPublicBUG REPORT

Description

As a watchlist user, I want watched items to be properly indicated in Special:RecentChangesLinked, so I can see which items I am watching in the list.

Background: Checked on several wikis and wikidata. Seems that before Thursday it worked okay.

Acceptance Criteria:

  • Restore previous behavior for watched pages in Special:RecentChangesLinked

Event Timeline

RWD created this task.Jun 27 2020, 9:04 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2020, 9:04 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJun 27 2020, 9:34 AM
DannyS712 changed the subtype of this task from "Task" to "Bug Report".Jun 27 2020, 9:39 AM

I think what is going on is...

When formatting the rows in recent changes, the code checks for non-null wl_user.

The SpecialRecentChangesLinked query does not include the wl_user column, so it acts as if these rows are not watched when outputting them.

ifried updated the task description. (Show Details)Thu, Jul 30, 4:05 PM
ifried updated the task description. (Show Details)Thu, Jul 30, 4:35 PM
ifried renamed this task from Items from watchlist no longer highlighted at Special:RecentChangesLinked to Items from watchlist no longer bolded at Special:RecentChangesLinked.Thu, Jul 30, 5:09 PM
ARamirez_WMF renamed this task from Items from watchlist no longer bolded at Special:RecentChangesLinked to Items from watchlist no longer bolded at Special:RecentChangesLinked [[SMALL]].Thu, Jul 30, 5:10 PM
ARamirez_WMF moved this task from To Be Estimated/Discussed to Estimated on the Community-Tech board.
Restricted Application edited projects, added Community-Tech; removed Community-Tech (Kanban-2020-21-Q1). · View Herald TranscriptThu, Jul 30, 5:12 PM
ifried renamed this task from Items from watchlist no longer bolded at Special:RecentChangesLinked [[SMALL]] to Items from watchlist no longer bolded at Special:RecentChangesLinked [[SMALL]] --> high priority.Thu, Jul 30, 9:02 PM

Change 617550 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@master] Fix bold of watched items on Special:RecentChangesLinked

https://gerrit.wikimedia.org/r/617550

@ifried The other consequence of this change (once T258310 is resolved) is that watched items on RecentChangesLinked will also have the clock icon.

Change 617550 merged by jenkins-bot:
[mediawiki/core@master] Fix bold of watched items on Special:RecentChangesLinked

https://gerrit.wikimedia.org/r/617550

@Samwilson Ah cool, so users will also see the clock icon for temporarily watched items on RecentChangesLinked, as well, once T258310 is resolved? And will the hover functionality work, as well? If so, that's great news. Thanks!

Yep and yep. :-)

Change 617809 had a related patch set uploaded (by Samwilson; owner: Samwilson):
[mediawiki/core@REL1_35] Fix bold of watched items on Special:RecentChangesLinked

https://gerrit.wikimedia.org/r/617809

This is merged and backported, and ready for QA.

Change 617809 merged by jenkins-bot:
[mediawiki/core@REL1_35] Fix bold of watched items on Special:RecentChangesLinked

https://gerrit.wikimedia.org/r/617809

Bold highlighting and the clock now works on Special:RecentChangesLinked.

Tested for permanently and temporarily watched pages. Expired watched pages are not highlighted.

Also tested with watchlist expiry disabled (on my local environment). Permanently watched pages are highlighted.

Test environment: https://test.wikipedia.org MediaWiki 1.36.0-wmf.3 (e73e964) 16:38, 7 August 2020