Page MenuHomePhabricator
Create Task
Maniphest T256568

Skins should not use $wgUseTwoButtonsSearchForm
Closed, ResolvedPublic
Actions

Description

These skins (among others, non-WMF deployed) make use of this variable to provide two-buttons search form (see https://www.mediawiki.org/wiki/MediaWiki?useskin=monobook).

This variable (which lives in core but not used there) is now removed (see T42622)

This task is to decide the future of the config option in these skins. If it's decided that any of these skin want continue supporting it, then the config would be moved inside the skin itself. Otherwise it would be removed completely.

Details

SubjectRepoBranchLines +/-
Remove usages of Revision object and $wgUseTwoButtonsSearchForm globalmediawiki/skins/DuskToDawnmaster+35 -36
Remove usage of $wgUseTwoButtonsSearchForm globalmediawiki/skins/Gamepressmaster+3 -7
Remove usage of $wgUseTwoButtonsSearchForm.mediawiki/skins/Bouquetmaster+3 -7
CologneBlue: Remove usage of $wgUseTwoButtonsSearchForm config variablemediawiki/skins/CologneBluemaster+12 -13
Modern: Remove usage of $wgUseTwoButtonsSearchForm config variablemediawiki/skins/Modernmaster+9 -21
MonoBook: Remove usage of $wgUseTwoButtonsSearchForm config variablemediawiki/skins/MonoBookmaster+5 -13
Nostalgia: Always show two-buttons search formmediawiki/skins/Nostalgiamaster+4 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

Ammarpad created this task.Jun 28 2020, 1:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 28 2020, 1:22 PM
Ammarpad added projects: MonoBook, Modern, CologneBlue, MediaWiki-Core-Skin-Architecture, Gamepress, DuskToDawn, Bouquet.Jun 28 2020, 1:25 PM
Ammarpad added a subtask: T42622: Deprecate and remove $wgUseTwoButtonsSearchForm from core.
Ammarpad added subscribers: Jdlrobson, matmarex.
Mainframe98 subscribed.Jun 28 2020, 1:44 PM

I'm not sure if I understand Nostalgia (this one will be simply removed completely). correctly; does that mean Nostalgia will no longer show two buttons? To preserve the look, I think Nostalgia should just display two buttons independent of MediaWiki.

Ammarpad added a comment.Jun 28 2020, 1:49 PM
In T256568#6262520, @Mainframe98 wrote:

I'm not sure if I understand Nostalgia (this one will be simply removed completely). correctly; does that mean Nostalgia will no longer show two buttons? To preserve the look, I think Nostalgia should just display two buttons independent of MediaWiki.

Thanks, I didn't thought of that.

Ammarpad updated the task description. (Show Details)Jun 28 2020, 1:50 PM
Ammarpad updated the task description. (Show Details)Jun 28 2020, 1:53 PM
gerritbot added a comment.Jun 28 2020, 2:08 PM

Change 608216 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Nostalgia@master] Nostalgia: Always show two-buttons search form

https://gerrit.wikimedia.org/r/c/mediawiki/skins/Nostalgia/ /608216

gerritbot added a project: Patch-For-Review.Jun 28 2020, 2:08 PM
Jdlrobson added a comment.Jun 29 2020, 10:29 PM

I think regarding these 3 skins we should consider them legacy and just do whatever they were doing before by default minus the configuration (so show 2 buttons on all of them).
That said 2 buttons is bad for usability, but I don't think it's in our interest to change norms on deprecated skins.

For users or site admins who want 1 button, CSS can be used to hide the latter button.

Jdlrobson moved this task from Backlog to Phase 3 - standardise template data on the MediaWiki-Core-Skin-Architecture board.Jun 29 2020, 10:29 PM
Jdlrobson triaged this task as Medium priority.Jun 29 2020, 11:26 PM
Ammarpad changed the status of subtask T42622: Deprecate and remove $wgUseTwoButtonsSearchForm from core from Open to Stalled.Jun 30 2020, 11:42 AM
Jdlrobson updated the task description. (Show Details)Jul 10 2020, 7:05 PM
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Jul 10 2020, 7:23 PM

Change 608216 merged by jenkins-bot:
[mediawiki/skins/Nostalgia@master] Nostalgia: Always show two-buttons search form

https://gerrit.wikimedia.org/r/608216

ReleaseTaggerBot added a project: MW-1.35-notes (1.35.0-wmf.41; 2020-07-14).Jul 10 2020, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 10 2020, 8:11 PM
gerritbot added a comment.Jul 11 2020, 7:52 AM

Change 611653 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/MonoBook@master] MonoBook: Remove usage of $wgUseTwoButtonsSearchForm config variable

https://gerrit.wikimedia.org/r/611653

gerritbot added a project: Patch-For-Review.Jul 11 2020, 7:52 AM
gerritbot added a comment.Jul 11 2020, 8:17 AM

Change 611675 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Modern@master] Modern: Remove usage of $wgUseTwoButtonsSearchForm config variable

https://gerrit.wikimedia.org/r/611675

Jdlrobson updated the task description. (Show Details)Jul 13 2020, 11:28 PM
gerritbot added a comment.Jul 13 2020, 11:34 PM

Change 611653 merged by jenkins-bot:
[mediawiki/skins/MonoBook@master] MonoBook: Remove usage of $wgUseTwoButtonsSearchForm config variable

https://gerrit.wikimedia.org/r/611653

gerritbot added a comment.Jul 13 2020, 11:34 PM

Change 611675 merged by jenkins-bot:
[mediawiki/skins/Modern@master] Modern: Remove usage of $wgUseTwoButtonsSearchForm config variable

https://gerrit.wikimedia.org/r/611675

Ammarpad mentioned this in rSMNBcc55b0d82243: MonoBook: Remove usage of $wgUseTwoButtonsSearchForm config variable.Jul 13 2020, 11:42 PM
Maintenance_bot removed a project: Patch-For-Review.Jul 14 2020, 12:10 AM
gerritbot added a comment.Jul 14 2020, 6:09 AM

Change 612465 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/CologneBlue@master] CologneBlue: Remove usage of $wgUseTwoButtonsSearchForm config variable

https://gerrit.wikimedia.org/r/612465

gerritbot added a project: Patch-For-Review.Jul 14 2020, 6:09 AM
gerritbot added a comment.Jul 14 2020, 2:57 PM

Change 612465 merged by jenkins-bot:
[mediawiki/skins/CologneBlue@master] CologneBlue: Remove usage of $wgUseTwoButtonsSearchForm config variable

https://gerrit.wikimedia.org/r/612465

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.1; 2020-07-21).Jul 14 2020, 3:00 PM
Jdlrobson renamed this task from Decide whether Monobook, CologneBlue and Modern should continue supporting $wgUseTwoButtonsSearchForm to Skins should not use $wgUseTwoButtonsSearchForm.Jul 14 2020, 3:01 PM
Jdlrobson removed projects: Patch-For-Review, MediaWiki-Core-Skin-Architecture, CologneBlue, Modern, MonoBook.
Jdlrobson updated the task description. (Show Details)
matmarex unsubscribed.Jul 14 2020, 9:46 PM
gerritbot added a comment.Jul 18 2020, 10:38 AM

Change 614030 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Bouquet@master] Remove usage of $wgUseTwoButtonsSearchForm.

https://gerrit.wikimedia.org/r/614030

gerritbot added a project: Patch-For-Review.Jul 18 2020, 10:38 AM
gerritbot added a comment.Jul 24 2020, 12:53 AM

Change 614030 merged by jenkins-bot:
[mediawiki/skins/Bouquet@master] Remove usage of $wgUseTwoButtonsSearchForm.

https://gerrit.wikimedia.org/r/614030

Ammarpad changed the status of subtask T42622: Deprecate and remove $wgUseTwoButtonsSearchForm from core from Stalled to Open.Jul 25 2020, 3:14 AM
Jdlrobson updated the task description. (Show Details)Aug 5 2020, 5:02 PM
Jdlrobson removed a project: Bouquet.Aug 5 2020, 5:05 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson closed subtask T42622: Deprecate and remove $wgUseTwoButtonsSearchForm from core as Resolved.Aug 5 2020, 7:17 PM
gerritbot added a comment.Aug 6 2020, 3:32 AM

Change 618647 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/DuskToDawn@master] Remove usages of Revision object and $wgUseTwoButtonsSearchForm global

https://gerrit.wikimedia.org/r/618647

gerritbot added a comment.Aug 6 2020, 3:34 AM

Change 618648 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/skins/Gamepress@master] Remove usage of $wgUseTwoButtonsSearchForm global

https://gerrit.wikimedia.org/r/618648

gerritbot added a comment.Aug 6 2020, 4:57 AM

Change 618648 merged by jenkins-bot:
[mediawiki/skins/Gamepress@master] Remove usage of $wgUseTwoButtonsSearchForm global

https://gerrit.wikimedia.org/r/618648

gerritbot added a comment.Aug 6 2020, 4:58 AM

Change 618647 merged by jenkins-bot:
[mediawiki/skins/DuskToDawn@master] Remove usages of Revision object and $wgUseTwoButtonsSearchForm global

https://gerrit.wikimedia.org/r/618647

Ammarpad closed this task as Resolved.Aug 6 2020, 5:11 AM
Ammarpad claimed this task.
Ammarpad updated the task description. (Show Details)
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL