| santhosh | |
| Jun 29 2020, 5:19 AM |
| F31910634: 608014-commit-message.png | |
| Jun 29 2020, 11:00 AM |
| F31910636: 607030-commit-message.png | |
| Jun 29 2020, 11:00 AM |
| F31910217: image.png | |
| Jun 29 2020, 5:19 AM |
An example from https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/608014/1:
In this commit message, the longest line is 84 characters. Which is with in the limits of 100 characters as doumented at https://www.mediawiki.org/wiki/Gerrit/Commit_message_guidelines#Body
As we can see, the lines are wrapped unnecessary and makes the reading difficult
Expected result:
Commit message body wrapped only at 100 characters or above
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | QChris | T186406 Polygerrit Outgoing reviews, Incoming reviews and Recently closed headings should be more different from commits | |||
| Resolved | None | T220801 PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+) | |||
| Resolved | QChris | T206453 Big empty space under patch description | |||
| Restricted Task | |||||
| Resolved | None | T210515 context links in diff don't use pointer cursor | |||
| Resolved | Paladox | T223278 "Server error: line 1:33 no viable alternative at character '['" when visiting particular patch | |||
| Restricted Task | |||||
| Resolved | hashar | T103990 Gerrit upload-pack send ALL references causing massive network I/O on common operations | |||
| Resolved | None | T195280 New Gerrit UI does not contain copyable Change-Id or parent commit id | |||
| Declined | Feature | None | T201246 Make a PolyGerrit plugin to welcome new users | ||
| Resolved | QChris | T254158 Gerrit 3.2 upgrade | |||
| Declined | None | T256588 Gerrit commit message body wrapped near 80 characters instead 100 |
The example at the top of the guide has the longest line at 65 characters. It used to state More details, wrap lines around 76 characters. (diff).
Gerrit uses some CSS magic to find the size of the box:
.commitMessage { ... /* Account for border and padding and rounding errors. */ max-width: calc(72ch + 2px + 2 * var(--spacing-m) + 0.4px); } #commitMessageEditor { min-width: calc(72ch + 2px + 2 * var(--spacing-m) + 0.4px) }
It used to be min-width: 72ch;.
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/607030
https://gerrit.wikimedia.org/r/c/mediawiki/extensions/ContentTranslation/+/608014/1
Our commit message validator code (integration/commit-message-validator) enforces 80 characters or less for the first line and accepts up to 100 characters in the body. I guess based on the wiki article.
def check_line(self, lineno): line = self._lines[lineno] # First line <=80 if lineno == 0 and len(line) > 80: if not RE_REVERT_SUBJECT.match(line): yield "First line should be <=80 characters" # No line >100 characters (unless it is only a URL) elif len(line) > 100 and not RE_URL.match(line): yield "Line should be <=100 characters"