Page MenuHomePhabricator

Hide the "Monitoring" tab?
Closed, InvalidPublic

Description

3.2 looks really nice, thanks for the smooth update!

There's a "Monitoring" tab in the top bar of the new Gerrit UI, maybe we should hide it by default (if that's possible). It's confusingly named (I initially assumed it allowed me to subscribed to some repo's activity) and the internal JavaMelody metrics are only relevant for people who keep Gerrit running, but not Gerrit users.

Event Timeline

QChris closed this task as Invalid.EditedJun 29 2020, 8:41 AM
QChris added a subscriber: QChris.

If it was visible by default, it would not be ideal. Agreed.

However, the Monitoring tab is hidden by default (see below).
It's only visible to users who can administrate the server (or who explicitly got access to JavaMelody).

And that includes you, as you are in the ops LDAP group, which are explicitly enabled access to JavaMelody. Hence, you get to see it.

Here are the relevant code links in case someone wants to verify:
https://gerrit.googlesource.com/plugins/javamelody/+/06e4d1ae08e470e1a4f7c394b852053e5e831c3b/src/main/java/com/googlesource/gerrit/plugins/javamelody/MonitoringTopMenu.java#29
https://gerrit.googlesource.com/plugins/javamelody/+/06e4d1ae08e470e1a4f7c394b852053e5e831c3b/src/main/java/com/googlesource/gerrit/plugins/javamelody/CapabilityChecker.java#50