Page MenuHomePhabricator

Embedded surveys are incorrectly shown even when embed element is missing
Closed, ResolvedPublic1 Estimated Story Points

Description

Due to a bug, when the embedded element is missing, the embedded survey becomes available to show as a randomized survey on the page.

This makes it unsafe to deploy T253112: Create survey for TechWish prototype announcements on dewiki and metawiki configuration-first. We should fix to make it easier to control survey visibility.

Event Timeline

awight created this task.Mon, Jun 29, 11:11 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMon, Jun 29, 11:11 AM
awight set the point value for this task to 1.Mon, Jun 29, 11:11 AM

Change 608300 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/QuickSurveys@master] Embedded surveys are hidden when no element is available

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/ /608300

awight claimed this task.Mon, Jun 29, 12:03 PM

Change 608300 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@master] Embedded surveys are hidden when no element is available

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/ /608300

Change 608477 had a related patch set uploaded (by Awight; owner: Awight):
[mediawiki/extensions/QuickSurveys@wmf/1.35.0-wmf.38] Embedded surveys are hidden when no element is available

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/ /608477

Change 608477 merged by jenkins-bot:
[mediawiki/extensions/QuickSurveys@wmf/1.35.0-wmf.38] Embedded surveys are hidden when no element is available

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/QuickSurveys/ /608477

Mentioned in SAL (#wikimedia-operations) [2020-06-30T11:28:31Z] <awight@deploy1001> Synchronized php-1.35.0-wmf.38/extensions/QuickSurveys: BACON: [[gerrit:608477|Embedded surveys are hidden when no element is available (T256627)]] (duration: 00m 56s)

Lena_WMDE closed this task as Resolved.Tue, Jul 7, 11:41 AM
Lena_WMDE moved this task from Demo to Done on the WMDE-QWERTY-Sprint-2020-06-24 board.