Update refinery-core Webrequest.isWikimediaHost
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	JAllemandou
	Jun 29 2020, 7:07 PM

Description

The Webrequest.isWikimediaHost should actually be Pageview.isWikimediaHost, and a new version of the Webrequest.isWikimediaHost should be less restrictive and return true for query.wikidata.org and test.wikimedia.org

Details

	Subject	Repo	Branch	Lines +/-
	Move pageview filters to PageviewDefinition; add Webrequest.isWMFHostname	analytics/refinery/source	master	+146 -52

Customize query in gerrit

Related Objects

Mentioned In: T256677: Refine should add field to indicate if event is from wikimedia domain instead of filtering

Event Timeline

JAllemandou created this task.Jun 29 2020, 7:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 29 2020, 7:07 PM

Ottomata mentioned this in T256677: Refine should add field to indicate if event is from wikimedia domain instead of filtering.Jun 29 2020, 7:15 PM

• fdans triaged this task as Medium priority.Jul 13 2020, 4:54 PM

• fdans moved this task from Incoming to Smart Tools for Better Data on the Analytics board.

Ottomata claimed this task.Dec 7 2020, 4:15 PM

Ottomata merged a task: T269597: Should Webrequest.isWikimediaHost return true for www.wikipedia.org.

Ottomata added a project: Analytics-Kanban.

Ottomata added subscribers: Ottomata, mforns, Milimetric, • fdans.

Change 646808 had a related patch set uploaded (by Ottomata; owner: Ottomata):
[analytics/refinery/source@master] Move pageview filters to PageviewDefinition; add Webrequest.isWMFDomain

https://gerrit.wikimedia.org/r/646808

gerritbot added a project: Patch-For-Review.Dec 7 2020, 7:16 PM

Ottomata moved this task from Next Up to In Code Review on the Analytics-Kanban board.Dec 14 2020, 4:23 PM

Change 646808 merged by Ottomata:
[analytics/refinery/source@master] Move pageview filters to PageviewDefinition; add Webrequest.isWMFHostname

https://gerrit.wikimedia.org/r/646808

Maintenance_bot removed a project: Patch-For-Review.Dec 21 2020, 7:10 PM

Ottomata moved this task from In Code Review to Ready to Deploy on the Analytics-Kanban board.Dec 22 2020, 7:51 PM

• fdans moved this task from Ready to Deploy to Done on the Analytics-Kanban board.Jan 21 2021, 5:52 PM

• fdans closed this task as Resolved.Mar 18 2021, 4:02 PM