Random example:
That URL should be https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/+/608433, not https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Wikibase/ /608433 (though the “space” URL also seems to work – Gerrit redirects it to the “plus” URL). This seems to have changed with the Gerrit 3.2 upgrade.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | QChris | T186406 Polygerrit Outgoing reviews, Incoming reviews and Recently closed headings should be more different from commits | |||
| Resolved | None | T220801 PolyGerrit 2.15 UI does not support custom dashboards (supported from in 2.16+) | |||
| Resolved | QChris | T206453 Big empty space under patch description | |||
| Restricted Task | |||||
| Resolved | None | T210515 context links in diff don't use pointer cursor | |||
| Resolved | Paladox | T223278 "Server error: line 1:33 no viable alternative at character '['" when visiting particular patch | |||
| Restricted Task | |||||
| Resolved | hashar | T103990 Gerrit upload-pack send ALL references causing massive network I/O on common operations | |||
| Resolved | None | T195280 New Gerrit UI does not contain copyable Change-Id or parent commit id | |||
| Declined | Feature | None | T201246 Make a PolyGerrit plugin to welcome new users | ||
| Resolved | QChris | T254158 Gerrit 3.2 upgrade | |||
| Resolved | QChris | T256729 gerritbot comment URLs replace + with space |
We noticed that during testing the build. But as you said the URLs work. Even if you copy/paste the link text and use it as URL, it works.
But we can work around the space vs. + to get a better URL, if it's annoying to see.
Actually ... since you filed the bug, it annoys you. I'll see to getting that changed :-)
I seem to remember a case where it didn’t work, but I’m not sure where it was.
Maybe when wikibugs copied those comments into IRC?
+1 that this looks broken and is thus somewhat confusing. + and space are kinda equivalent in the query part of the URL, but not in the path.
Also will probably break autolinking in email clients etc.
Change 608953 had a related patch set uploaded (by QChris; owner: Christian Aistleitner):
[operations/puppet@production] gerrit: Make implicit its templates explicit
Change 608954 had a related patch set uploaded (by QChris; owner: Christian Aistleitner):
[operations/puppet@production] gerrit: Format short gerrit URLs in phabricator comments
Change 608953 merged by Dzahn:
[operations/puppet@production] gerrit: Make implicit its templates explicit
Change 608954 merged by Dzahn:
[operations/puppet@production] gerrit: Format short gerrit URLs in phabricator comments