Page MenuHomePhabricator

Travis CI builds failing on "The password entered is in a list of very commonly used passwords."
Closed, ResolvedPublic

Description

https://travis-ci.com/github/wikimedia/mediawiki/jobs/356131146

Internal error when setting a password for the admin "admin": The password entered is in a list of very commonly used passwords. Please choose a more unique password.

Started with:

I guess the old method bypassed this.

Event Timeline

Krinkle created this task.Jul 1 2020, 2:01 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 1 2020, 2:01 AM
Krinkle claimed this task.Jul 1 2020, 2:02 AM
Krinkle triaged this task as Low priority.
Krinkle updated the task description. (Show Details)
Krinkle added subscribers: Ammarpad, Pchelolo.

Change 608750 had a related patch set uploaded (by Krinkle; owner: Krinkle):
[mediawiki/core@master] build: Change Travis CI temporary password

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608750

Ammarpad added a subscriber: Tgr.EditedJul 1 2020, 5:47 AM

I guess the old method bypassed this.

This is a problem that started in August 2016 when the PasswordError exception was removed from the User::setPassowrd() method in this commt: Remove $wgDisableAuthManager. The method was replaced to call internal method that returns boolean but Installer was never updated.

So apparently it never caught any PasswordError exception since that year because none will be thrown, and that's why this password never raised an issue. The update in rMW3df9742b3203 just helped to unravel and fix that problem; and now that we are doing it correctly the password failed the verification hard.

Change 608750 merged by jenkins-bot:
[mediawiki/core@master] build: Change Travis CI temporary password

https://gerrit.wikimedia.org/r/c/mediawiki/core/ /608750

Krinkle closed this task as Resolved.Jul 1 2020, 5:51 PM