Page MenuHomePhabricator
Create Task
Maniphest T256836

Merge mediawiki.rcfilters.filters.dm into mediawiki.rcfilters.filters.ui
Open, Needs TriagePublic
Actions

Description

The mediawiki.rcfilters.filters.dm resource loader module is only used in two places: QUnitTestResources, and as a dependency for mediawiki.rcfilters.filters.ui. I suggest that the dm module be merged with the ui module, and the ui module be used in the QUnit test instead.

Global search reveals no uses of the mediawiki.rcfilters.filters.ui module on-wiki

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
RCFilters: Merge mw.rcfilters.init.js into mw.rcfilters.jsDannyS712mediawiki/coremaster+156 -177
RCFilters: Merge mediawiki.rcfilters.filters.dm into ui moduleDannyS712mediawiki/coremaster+40 -34
Customize query in gerrit

Related Objects

Event Timeline

DannyS712 created this task.Jul 1 2020, 6:13 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptJul 1 2020, 6:13 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.Jul 1 2020, 6:14 AM
Aklapper added a project: MediaWiki-Recent-changes.Jul 1 2020, 7:49 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptJul 1 2020, 7:49 AM
Krinkle edited projects, added: Performance-Team (Radar); removed: Performance-Team.Jul 1 2020, 5:52 PM
Krinkle subscribed.

Ref T193826: Organise module files in directories based on their module name.

Krinkle moved this task from Limbo to Watching on the Performance-Team (Radar) board.Jul 1 2020, 5:52 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
Krinkle moved this task from Watching to Perf recommendation on the Performance-Team (Radar) board.Apr 15 2021, 9:12 PM
gerritbot added a comment.Sep 20 2021, 9:33 PM

Change 722405 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Merge mediawiki.rcfilters.filters.(dm|ui) into one module

https://gerrit.wikimedia.org/r/722405

gerritbot added a project: Patch-For-Review.Sep 20 2021, 9:33 PM
gerritbot added a comment.Oct 8 2021, 3:08 AM

Change 727499 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] Merge mw.rcfilters.init.js into mw.rcfilters.js

https://gerrit.wikimedia.org/r/727499

gerritbot added a comment.Oct 9 2021, 2:43 AM

Change 722405 merged by jenkins-bot:

[mediawiki/core@master] RCFilters: Merge mediawiki.rcfilters.filters.dm into ui module

https://gerrit.wikimedia.org/r/722405

ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 9 2021, 3:00 AM
gerritbot added a comment.Oct 13 2021, 12:35 AM

Change 727499 merged by jenkins-bot:

[mediawiki/core@master] RCFilters: Merge mw.rcfilters.init.js into mw.rcfilters.js

https://gerrit.wikimedia.org/r/727499

ReleaseTaggerBot edited projects, added: MW-1.38-notes (1.38.0-wmf.5; 2021-10-19); removed: MW-1.38-notes (1.38.0-wmf.4; 2021-10-12).Oct 13 2021, 1:00 AM
Maintenance_bot removed a project: Patch-For-Review.Oct 13 2021, 1:10 AM
Krinkle edited projects, added: Wikimedia-Performance-recommendation; removed: Performance-Team (Radar).Aug 18 2023, 8:41 PM
KStoller-WMF removed projects: Growth-Team-Filtering, Growth-Team.Sep 13 2024, 5:42 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits